Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and tweaks #2953

Merged
merged 9 commits into from
Jan 21, 2025
Merged

Fixes and tweaks #2953

merged 9 commits into from
Jan 21, 2025

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Jan 20, 2025

  • Return "no implemented" error when trying to get info about RPS transactions
  • Fix typo in `protocol_changes.json' for testnet4
  • sat_per_vbyte parameter accepts float
  • Don't retry to get vin info when parsing mempool
  • Add stacktrace when warning from bitcoind

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft January 20, 2025 07:58
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pylint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@ouziel-slama ouziel-slama marked this pull request as ready for review January 20, 2025 10:06
@ouziel-slama ouziel-slama merged commit 9a82e0b into develop Jan 21, 2025
19 checks passed
@ouziel-slama ouziel-slama deleted the fixes branch January 21, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants