Check addresses and hashes format #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ouziel-slama
commented
Jan 17, 2025
•
ouziel-slama
commented
- Double-check the spelling and grammar of all strings, code comments, etc.
- Double-check that all code is deterministic that needs to be
- Add tests to cover any new or revised logic
- Ensure that the test suite passes
- Update the project release notes
- Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if str_arg is not None: | ||
| if arg_name.startswith("address"): | ||
| addresses = str_arg.split(",") | ||
| if not all([address.is_valid_address(addr) for addr in addresses]): |
Check warning
Code scanning / pylint
Use a generator instead 'all(address.is_valid_address(addr) for addr in addresses)'. Warning
| setup(config.NETWORK_NAME) | ||
|
|
||
|
|
||
| def is_valid_tx_hash(hash): |
Check warning
Code scanning / pylint
Redefining built-in 'hash'. Warning
| def send(self, data, retry=0): | ||
| try: | ||
| self.client.send(data) | ||
| except Exception as e: |
Check warning
Code scanning / pylint
Catching too general exception Exception. Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.