Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and tweaks #2947

Merged
merged 21 commits into from
Jan 19, 2025
Merged

Fixes and tweaks #2947

merged 21 commits into from
Jan 19, 2025

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Jan 16, 2025

  • Fix ignored deprecated parameters in Compose API
  • Add no_dispense parameter to not automatically compose a dispense transaction even if the destination is a dispenser
  • Fix get mempool events by addresses endpoint
  • Retry ten times on telemetry request error
  • Check addresses and hashes format in parameters

  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft January 16, 2025 16:12
@ouziel-slama ouziel-slama changed the title Fixes Compose API fix and tweal Jan 16, 2025
@ouziel-slama ouziel-slama changed the title Compose API fix and tweal Compose API fix and tweak Jan 16, 2025
@ouziel-slama ouziel-slama marked this pull request as ready for review January 16, 2025 16:38
@ouziel-slama ouziel-slama changed the title Compose API fix and tweak Compose API fixes and tweaks Jan 17, 2025
@ouziel-slama ouziel-slama changed the title Compose API fixes and tweaks Fixes and tweaks Jan 17, 2025
def send(self, data, retry=0):
try:
self.client.send(data)
except Exception as e:

Check warning

Code scanning / pylint

Catching too general exception Exception. Warning

Catching too general exception Exception.
@ouziel-slama ouziel-slama merged commit 9fe8159 into develop Jan 19, 2025
19 checks passed
@ouziel-slama ouziel-slama deleted the fixes branch January 19, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants