Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2899

Merged
merged 7 commits into from
Jan 4, 2025
Merged

Fixes #2899

merged 7 commits into from
Jan 4, 2025

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Jan 4, 2025 •
edited
Loading

  • Search also by destination in get sends by address endpoints
  • Add source_address and destination_address in sends table
  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft January 4, 2025 11:41
@ouziel-slama ouziel-slama changed the title Fixes Fixe Get Sends By Address and send_type Jan 4, 2025
@ouziel-slama ouziel-slama marked this pull request as ready for review January 4, 2025 15:16
@ouziel-slama ouziel-slama changed the title Fixe Get Sends By Address and send_type Fixes Jan 4, 2025
@ouziel-slama ouziel-slama merged commit 39315ef into develop Jan 4, 2025
11 of 15 checks passed
@ouziel-slama ouziel-slama deleted the fixes branch January 4, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouziel-slama @adamkrellenstein @Ouziel