Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unification branch #37

Merged
merged 26 commits into from
Dec 10, 2024
Merged

Unification branch #37

merged 26 commits into from
Dec 10, 2024

Conversation

marcobonici
Copy link
Member

The goal of this PR is to finally merge into develop the new unification approach.

This will enable us to use more EFT code simoultaneously, without breaking the code.
Also, check the AP before merging.

@marcobonici marcobonici self-assigned this Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 40.18692% with 64 lines in your changes missing coverage. Please review.

Project coverage is 40.55%. Comparing base (6c54d31) to head (56be36c).
Report is 27 commits behind head on develop.

Files with missing lines Patch % Lines
src/utils.jl 6.89% 27 Missing ⚠️
src/background.jl 68.51% 17 Missing ⚠️
src/eft_commands.jl 0.00% 13 Missing ⚠️
src/neural_networks.jl 0.00% 6 Missing ⚠️
src/projection.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #37       +/-   ##
============================================
- Coverage    57.39%   40.55%   -16.85%     
============================================
  Files            7        7               
  Lines          514      508        -6     
============================================
- Hits           295      206       -89     
- Misses         219      302       +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcobonici marcobonici merged commit 388fefa into develop Dec 10, 2024
5 of 7 checks passed
@marcobonici marcobonici mentioned this pull request Dec 10, 2024
@marcobonici marcobonici mentioned this pull request Dec 10, 2024
@marcobonici marcobonici deleted the unification_branch branch January 18, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant