Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ap ad #30

Merged
merged 12 commits into from
Sep 4, 2024
Merged

Ap ad #30

merged 12 commits into from
Sep 4, 2024

Conversation

marcobonici
Copy link
Member

With this request, we have implemented a refactoring of the AP effect. In particular, the AP is now compatible with Zygote.
Closes #27

@marcobonici marcobonici added the enhancement New feature or request label Sep 4, 2024
@marcobonici marcobonici self-assigned this Sep 4, 2024
@marcobonici marcobonici linked an issue Sep 4, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 55.48%. Comparing base (2699b1b) to head (e50fb31).

Files with missing lines Patch % Lines
src/projection.jl 89.47% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #30       +/-   ##
============================================
+ Coverage    41.63%   55.48%   +13.85%     
============================================
  Files            7        7               
  Lines          490      492        +2     
============================================
+ Hits           204      273       +69     
+ Misses         286      219       -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcobonici marcobonici merged commit 69c7636 into develop Sep 4, 2024
9 checks passed
@marcobonici marcobonici deleted the AP_ad branch September 5, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differentiable AP
1 participant