Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.5] Disable reference types #2349

Merged
merged 2 commits into from
Jan 27, 2025
Merged

[1.5] Disable reference types #2349

merged 2 commits into from
Jan 27, 2025

Conversation

chipshort
Copy link
Collaborator

also found bulk memory proposal was enabled by default and disabled that

@chipshort chipshort marked this pull request as ready for review January 27, 2025 10:23
aumetra
aumetra approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval from beyond the abyss (boarded plane)

webmaster128
webmaster128 reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A CHANGELOG entry would be good for this, diff LGTM

@chipshort chipshort merged commit dd5b03c into release/1.5 Jan 27, 2025
27 checks passed
@chipshort chipshort deleted the co/disable-ref-types branch January 27, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

@aumetra aumetra aumetra approved these changes

@kulikthebird kulikthebird Awaiting requested review from kulikthebird

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chipshort @webmaster128 @aumetra