-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wasmer to 4.3 #2147
Update wasmer to 4.3 #2147
Conversation
Let's try to reduce the parallelization first. Cargo probably gets a value of 32 or 64 when asking the system for CPU count. For one other job we already have this:
|
Thought for a second that it might have been the cache, but can't be because the lockfile changed during the Wasmer upgrade.. weird. |
Wanna try to plug in an alternative linker since this seems to die on the ld invocation? |
Otherwise I'd even say let's go for |
But isn't that what is failing here? The compilation with |
NVM yeah, you're right. I was mixing up |
Had to switch the coverage job to alpine 3.19 in order to get a somewhat recent mold version, but it seems to help with the memory usage |
I don't have strong opinions which coverage tool to use. But if we change it, let's please do that in a separate PR |
Yep, definitely. But it seems like using a different linker did the trick already, so this looks good to go |
closes #1628
Wasmer bumped their module version, so no need to bump our
MODULE_SERIALIZATION_VERSION
Looks like the coverage job is running out of memory again.
@webmaster128 Can we bump that to a larger resource class?
The
package_vm_windows
job was also failing. I did a fullcargo update
to fix that (I couldn't easily figure out what package caused the linker problems. If you have tips, please tell me), followed by downgradingwat
to1.207.0
(instead of1.208.1
) to avoid their Rust 1.76 requirement.