chore: Fix after review

CosmWasm · Feb 12, 2025 · 73a4d50 · 73a4d50
1 parent 7c094bb
commit 73a4d50
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,8 +13,10 @@ and this project adheres to
 - cosmwasm-std: Implement `From<Uint64> for u{64,128}`,
   `From<Uint128> for u128`, `From<Int64> for i{64,128}`, and
   `From<Int128> for i128` ([#2268])
+- cosmwasm-std: Add ICS-20 TransferV2 ([#2317])
 
 [#2268]: https://github.com/CosmWasm/cosmwasm/issues/2268
+[#2317]: https://github.com/CosmWasm/cosmwasm/pull/2317
 
 ## Fixed
 

diff --git a/packages/std/src/ibc/transfer_msg_builder_v2.rs b/packages/std/src/ibc/transfer_msg_builder_v2.rs
@@ -166,11 +166,8 @@ impl<Memo: AddDstCallbackPossible, TransferType> TransferMsgBuilderV2<Memo, Tran
     }
 }
 
-impl<Memo: ForwardingPossible> TransferMsgBuilderV2<Memo, EmptyTransferType> {
-    /// Adds forwarding data.
-    /// It is worth to notice that the builder does not allow to add forwarding data along with
-    /// source callback. It is discouraged in the IBC docs:
-    /// https://ibc.cosmos.network/v9/middleware/callbacks/overview/#known-limitations
+impl<Memo> TransferMsgBuilderV2<Memo, EmptyTransferType> {
+    /// Creates a direct transfer without forwarding data.
     pub fn with_direct_transfer(
         self,
         channel_id: String,
@@ -190,6 +187,9 @@ impl<Memo: ForwardingPossible> TransferMsgBuilderV2<Memo, EmptyTransferType> {
     }
 
     /// Adds forwarding data.
+    /// More information can be found in the IBC doc:
+    /// https://ibc.cosmos.network/main/apps/transfer/messages/#msgtransfer
+    ///
     /// It is worth to notice that the builder does not allow to add forwarding data along with
     /// source callback. It is discouraged in the IBC docs:
     /// https://ibc.cosmos.network/v9/middleware/callbacks/overview/#known-limitations
@@ -213,7 +213,10 @@ impl<Memo: ForwardingPossible> TransferMsgBuilderV2<Memo, EmptyTransferType> {
         }
     }
 
-    /// Adds forwarding data.
+    /// Adds forwarding data with an unwinding flag set.
+    /// More information can be found in the IBC doc:
+    /// https://ibc.cosmos.network/main/apps/transfer/messages/#msgtransfer
+    ///
     /// It is worth to notice that the builder does not allow to add forwarding data along with
     /// source callback. It is discouraged in the IBC docs:
     /// https://ibc.cosmos.network/v9/middleware/callbacks/overview/#known-limitations