feat: support multiple accounts in SNAP #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Julink-eth and
wantedsystem
and removed request for
a team
stanleyyconsensys
changed the title
khanti42
previously approved these changes
Feb 6, 2025
Base automatically changed from
refactor/account-discovery-bussiness-logic
to
main
February 6, 2025 12:40
khanti42
approved these changes
Feb 6, 2025
|
|
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add multiple account supports in SNAP
Changes:
starkNet_listAccountsstarkNet_swtichAccountstarkNet_addAccountstarkNet_toggleAccountVisibilitystarkNet_getStoredUserAccountsgetCurrentAccountandswitchAccountinAccountServiceBEGIN_COMMIT_OVERRIDE
feat: Enable multiple accounts support in SNAP with new RPC API
starkNet_listAccounts,starkNet_swtichAccount,starkNet_addAccount,starkNet_toggleAccountVisibility(#504, #477, #478, #474, #476)END_COMMIT_OVERRIDE