feat: Add RPC starkNet_toggleAccountVisibility to toggle the account visibility
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Julink-eth and
jonesho
and removed request for
a team
Base automatically changed from
chore/unblock-account-create-limit
to
feat/enable-multiple-accounts
January 27, 2025 01:27
|
|
stanleyyconsensys
merged commit 492e311
into
feat/enable-multiple-accounts
14 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
* feat: add account service (#470) * feat: add account service * feat: add account service factory (#472) * feat: add account service factory * fix: rename deployPayload * refactor: adopt account discovery (#473) * feat: add account serviceΩ --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_addAccount ` (#474) * feat: add `AddAccount` RPC * feat: add max account create limit --------- Co-authored-by: khanti42 <[email protected]> * feat: add account UI (#475) * feat: add account ui --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_getCurrentAccount` (#476) * feat: add get current account RPC * fix: add some detail comment on contract discovery * fix: comments on test title --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_listAccounts` (#477) * feat: add list accounts rpc * fix: lint * fix: add some detail comment on contract discovery * fix: comments on test title --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_switchAccount` (#478) * feat: add swtich account rpc --------- Co-authored-by: khanti42 <[email protected]> * chore: set new account to current current in RPC `starkNet_addAccount` (#479) * chore: set new account to current in snap * fix: lint * chore: update logger mocking * feat: add UI hooks for manage multi accounts (#480) * feat: add manage multi account hooks * fix: remove non exist component * fix: var naming in UI * chore: update logger mocking * chore: update setAccounts logic in UI * chore: remove duplicate when set account from UI * chore: remove non necessary account array in UI * chore: update get current account rpc to return data from state only (#483) * feat: [Wallet-UI] account selection dropdown (#482) * feat: add account service * chore: fix lint * chore: update account contract discovery logic * fix: code comment * chore: add discovery logic description * fix: lint * feat: add account service factory * fix: rename deployPayload * chore: adopt account discovery in RPCs * chore: update execute txn test * fix: execute test * fix: account discovery bug * fix: discovery logic * feat: add `AddAccount` RPC * feat: add max account create limit * fix: add `isMaxAccountLimitExceeded` unit test * feat: add account ui * fix: account deploy require result * fix: lint * fix: lint * feat: add get current account RPC * feat: add list accounts rpc * fix: lint * feat: add swtich account rpc * fix: comments on add account icon * chore: set new account to current in snap * fix: lint * feat: add manage multi account hooks * fix: remove non exist component * fix: var naming in UI * chore: update logger mocking * chore: update setAccounts logic in UI * chore: remove duplicate when set account from UI * chore: remove non necessary account array in UI * feat: account selection dropdown * chore: connect ui to snap for switch account * chore: fix comments * chore: lint + prettier * chore: fix bugs qa * chore: fix comments * chore: revert snap changes * chore: revert snap changes --------- Co-authored-by: stanleyyuen <[email protected]> * fix: after a account switched, the address is not reflected on the Snap home page UI (#487) * fix: use correct account on snap homepage * fix: eof * fix: account contract isRequiredDeploy Upgrade order mismatch (#491) * fix: typo of SwitchAccount RPC api name * feat: account event change get starknet (#484) * feat: get-starknet support for account change event * chore: lint + prettier * chore: fix comments * chore: lint + prettier * fix: use fromState=true * chore: fix comments * chore: fix tests * chore: fix comments * chore: fix comments * chore: fix comments * fix: rollback change --------- Co-authored-by: stanleyyuen <[email protected]> * chore: add unit test for get-starknet event (#490) * chore: add unit test * chore: update wallet test in get-starknet * chore: block init event not send out --------- Co-authored-by: stanleyyuen <[email protected]> * fix: incorrect switch account rpc endpoint (#496) * chore: unblock account create limit (#493) Co-authored-by: khanti42 <[email protected]> * feat: Add RPC `starkNet_toggleAccountVisibility` to toggle the account visibility (#494) * chore: unblock account create limit * feat: add toggle account visibility RPC * fix: typo * fix: add permission * feat: wallet-ui multiple accounts scrollbar (#499) * feat: wallet-ui multiple accounts scrollbar * feat: wallet-ui multiple accounts hide/unhide feature (#501) * feat: wallet-ui multiple accounts scrollbar * feat: hide account feature * feat: show account feature * chore: fix sonar qube * chore: fix comments * chore: lint * chore: fix comments * chore: lint * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: currentAccount is always defined in walletSlice redux state (#502) * chore: fix comments * chore: fix comments * chore: add missing translation * chore: lint + test * refactor: add account discover service * feat: support multiple account in SNAP * feat: watch the SNAP current account * fix: lint * feat: support multiple account * chore: qa fix * chore: lint * chore: lint --------- Co-authored-by: Stanley Yuen <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
* feat: add account service (#470) * feat: add account service * feat: add account service factory (#472) * feat: add account service factory * fix: rename deployPayload * refactor: adopt account discovery (#473) * feat: add account serviceΩ --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_addAccount ` (#474) * feat: add `AddAccount` RPC * feat: add max account create limit --------- Co-authored-by: khanti42 <[email protected]> * feat: add account UI (#475) * feat: add account ui --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_getCurrentAccount` (#476) * feat: add get current account RPC * fix: add some detail comment on contract discovery * fix: comments on test title --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_listAccounts` (#477) * feat: add list accounts rpc * fix: lint * fix: add some detail comment on contract discovery * fix: comments on test title --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_switchAccount` (#478) * feat: add swtich account rpc --------- Co-authored-by: khanti42 <[email protected]> * chore: set new account to current current in RPC `starkNet_addAccount` (#479) * chore: set new account to current in snap * fix: lint * chore: update logger mocking * feat: add UI hooks for manage multi accounts (#480) * feat: add manage multi account hooks * fix: remove non exist component * fix: var naming in UI * chore: update logger mocking * chore: update setAccounts logic in UI * chore: remove duplicate when set account from UI * chore: remove non necessary account array in UI * chore: update get current account rpc to return data from state only (#483) * feat: [Wallet-UI] account selection dropdown (#482) * feat: add account service * chore: fix lint * chore: update account contract discovery logic * fix: code comment * chore: add discovery logic description * fix: lint * feat: add account service factory * fix: rename deployPayload * chore: adopt account discovery in RPCs * chore: update execute txn test * fix: execute test * fix: account discovery bug * fix: discovery logic * feat: add `AddAccount` RPC * feat: add max account create limit * fix: add `isMaxAccountLimitExceeded` unit test * feat: add account ui * fix: account deploy require result * fix: lint * fix: lint * feat: add get current account RPC * feat: add list accounts rpc * fix: lint * feat: add swtich account rpc * fix: comments on add account icon * chore: set new account to current in snap * fix: lint * feat: add manage multi account hooks * fix: remove non exist component * fix: var naming in UI * chore: update logger mocking * chore: update setAccounts logic in UI * chore: remove duplicate when set account from UI * chore: remove non necessary account array in UI * feat: account selection dropdown * chore: connect ui to snap for switch account * chore: fix comments * chore: lint + prettier * chore: fix bugs qa * chore: fix comments * chore: revert snap changes * chore: revert snap changes --------- Co-authored-by: stanleyyuen <[email protected]> * fix: after a account switched, the address is not reflected on the Snap home page UI (#487) * fix: use correct account on snap homepage * fix: eof * fix: account contract isRequiredDeploy Upgrade order mismatch (#491) * fix: typo of SwitchAccount RPC api name * feat: account event change get starknet (#484) * feat: get-starknet support for account change event * chore: lint + prettier * chore: fix comments * chore: lint + prettier * fix: use fromState=true * chore: fix comments * chore: fix tests * chore: fix comments * chore: fix comments * chore: fix comments * fix: rollback change --------- Co-authored-by: stanleyyuen <[email protected]> * chore: add unit test for get-starknet event (#490) * chore: add unit test * chore: update wallet test in get-starknet * chore: block init event not send out --------- Co-authored-by: stanleyyuen <[email protected]> * fix: incorrect switch account rpc endpoint (#496) * chore: unblock account create limit (#493) Co-authored-by: khanti42 <[email protected]> * feat: Add RPC `starkNet_toggleAccountVisibility` to toggle the account visibility (#494) * chore: unblock account create limit * feat: add toggle account visibility RPC * fix: typo * fix: add permission * feat: wallet-ui multiple accounts scrollbar (#499) * feat: wallet-ui multiple accounts scrollbar * feat: wallet-ui multiple accounts hide/unhide feature (#501) * feat: wallet-ui multiple accounts scrollbar * feat: hide account feature * feat: show account feature * chore: fix sonar qube * chore: fix comments * chore: lint * chore: fix comments * chore: lint * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: currentAccount is always defined in walletSlice redux state (#502) * chore: fix comments * chore: fix comments * chore: add missing translation * chore: lint + test * chore: qa fix * chore: account name in state optional * chore: default account name * chore: lint+test * feat: rpc setAccountName * feat: get next account index, set account on account creation * chore: rollback yarn.lock * chore: fix comments * chore: fix comments * chore: fix comments * chore: add AccountMissMatchError * chore: update account state test helper * chore: add defaultAccountIndex config * chore: update account service * chore: lint * chore: use new account state * chore: fix tests * chore: set account name * chore: fix comments * chore: fix comments --------- Co-authored-by: Stanley Yuen <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
* feat: add account service (#470) * feat: add account service * feat: add account service factory (#472) * feat: add account service factory * fix: rename deployPayload * refactor: adopt account discovery (#473) * feat: add account serviceΩ --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_addAccount ` (#474) * feat: add `AddAccount` RPC * feat: add max account create limit --------- Co-authored-by: khanti42 <[email protected]> * feat: add account UI (#475) * feat: add account ui --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_getCurrentAccount` (#476) * feat: add get current account RPC * fix: add some detail comment on contract discovery * fix: comments on test title --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_listAccounts` (#477) * feat: add list accounts rpc * fix: lint * fix: add some detail comment on contract discovery * fix: comments on test title --------- Co-authored-by: khanti42 <[email protected]> * feat: add new RPC `starkNet_switchAccount` (#478) * feat: add swtich account rpc --------- Co-authored-by: khanti42 <[email protected]> * chore: set new account to current current in RPC `starkNet_addAccount` (#479) * chore: set new account to current in snap * fix: lint * chore: update logger mocking * feat: add UI hooks for manage multi accounts (#480) * feat: add manage multi account hooks * fix: remove non exist component * fix: var naming in UI * chore: update logger mocking * chore: update setAccounts logic in UI * chore: remove duplicate when set account from UI * chore: remove non necessary account array in UI * chore: update get current account rpc to return data from state only (#483) * feat: [Wallet-UI] account selection dropdown (#482) * feat: add account service * chore: fix lint * chore: update account contract discovery logic * fix: code comment * chore: add discovery logic description * fix: lint * feat: add account service factory * fix: rename deployPayload * chore: adopt account discovery in RPCs * chore: update execute txn test * fix: execute test * fix: account discovery bug * fix: discovery logic * feat: add `AddAccount` RPC * feat: add max account create limit * fix: add `isMaxAccountLimitExceeded` unit test * feat: add account ui * fix: account deploy require result * fix: lint * fix: lint * feat: add get current account RPC * feat: add list accounts rpc * fix: lint * feat: add swtich account rpc * fix: comments on add account icon * chore: set new account to current in snap * fix: lint * feat: add manage multi account hooks * fix: remove non exist component * fix: var naming in UI * chore: update logger mocking * chore: update setAccounts logic in UI * chore: remove duplicate when set account from UI * chore: remove non necessary account array in UI * feat: account selection dropdown * chore: connect ui to snap for switch account * chore: fix comments * chore: lint + prettier * chore: fix bugs qa * chore: fix comments * chore: revert snap changes * chore: revert snap changes --------- Co-authored-by: stanleyyuen <[email protected]> * fix: after a account switched, the address is not reflected on the Snap home page UI (#487) * fix: use correct account on snap homepage * fix: eof * fix: account contract isRequiredDeploy Upgrade order mismatch (#491) * fix: typo of SwitchAccount RPC api name * feat: account event change get starknet (#484) * feat: get-starknet support for account change event * chore: lint + prettier * chore: fix comments * chore: lint + prettier * fix: use fromState=true * chore: fix comments * chore: fix tests * chore: fix comments * chore: fix comments * chore: fix comments * fix: rollback change --------- Co-authored-by: stanleyyuen <[email protected]> * chore: add unit test for get-starknet event (#490) * chore: add unit test * chore: update wallet test in get-starknet * chore: block init event not send out --------- Co-authored-by: stanleyyuen <[email protected]> * fix: incorrect switch account rpc endpoint (#496) * chore: unblock account create limit (#493) Co-authored-by: khanti42 <[email protected]> * feat: Add RPC `starkNet_toggleAccountVisibility` to toggle the account visibility (#494) * chore: unblock account create limit * feat: add toggle account visibility RPC * fix: typo * fix: add permission * feat: wallet-ui multiple accounts scrollbar (#499) * feat: wallet-ui multiple accounts scrollbar * feat: wallet-ui multiple accounts hide/unhide feature (#501) * feat: wallet-ui multiple accounts scrollbar * feat: hide account feature * feat: show account feature * chore: fix sonar qube * chore: fix comments * chore: lint * chore: fix comments * chore: lint * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: currentAccount is always defined in walletSlice redux state (#502) * chore: fix comments * chore: fix comments * chore: add missing translation * chore: lint + test * chore: qa fix * chore: account name in state optional * chore: default account name * chore: lint+test * feat: rpc setAccountName * feat: get next account index, set account on account creation * chore: rollback yarn.lock * chore: rollback yarn.lock * feat: add account pop-up with name edition * chore: lint * chore: updating language file * chore: lint * chore: fix comments * chore: fix comments * chore: fix comments * chore: fix comments * chore: add AccountMissMatchError * chore: update account state test helper * chore: add defaultAccountIndex config * chore: update account service * chore: lint * chore: use new account state * chore: fix tests * chore: set account name * chore: lint * chore: fix comments * chore: fix comments * chore: remove getNextAccountIndex * chore: use placeholder instead of value * chore: handle comments * feat: update account name from account details page in wallet-ui (#510) * feat: update account name from account details * chore: fix comments * chore: style ui * chore: remove getNextAccountIndex * chore: fix transactions list use effect * chore: fix transactions list use effect dont trigger for defaultAccount * chore: lint * chore: fix comments * chore: fix comments * chore: refine account name management UI (#515) * chore: refine account name management * fix: react useEffect dependency --------- Co-authored-by: Stanley Yuen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is add a new RPC
starkNet_toggleAccountVisibilityto toggle the account visibilityChanges:
starkNet_toggleAccountVisibilityand allowlist from the permission (restricted)removedAccountsrelated codeAccountService, we can pass a json data into theAccountobject, hence it can store it when reflect the correct data when usingserialize