Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: localization #471

Merged
merged 12 commits into from
Jan 16, 2025
Merged

feat: localization #471

merged 12 commits into from
Jan 16, 2025

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Jan 9, 2025 •
edited by stanleyyconsensys
Loading

Description

This PR

  • introduces localisation for the Snap, with fallback to english
  • translates components, homepage, oninstall and onupdate hooks text into the chosen language
  • adds translation for English and French

BEGIN_COMMIT_OVERRIDE

chore: enable localisation for the Snap.

END_COMMIT_OVERRIDE

@khanti42 khanti42 marked this pull request as ready for review January 13, 2025 02:29
@khanti42 khanti42 requested a review from a team as a code owner January 13, 2025 02:29
@khanti42 khanti42 requested review from Julink-eth and stanleyyconsensys and removed request for a team January 13, 2025 02:29
stanleyyconsensys
stanleyyconsensys requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for work, some comments left

packages/starknet-snap/locales/en.json Outdated Show resolved Hide resolved
packages/starknet-snap/locales/en.json Show resolved Hide resolved
packages/starknet-snap/locales/en.json Show resolved Hide resolved
packages/starknet-snap/locales/en.json Show resolved Hide resolved
packages/starknet-snap/src/on-home-page.test.ts Show resolved Hide resolved
packages/starknet-snap/src/utils/snapUtils.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/utils/snapUtils.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/utils/snapUtils.ts Outdated Show resolved Hide resolved
packages/starknet-snap/test/src/addNetwork.test.ts Outdated Show resolved Hide resolved
packages/starknet-snap/test/src/createAccount.test.ts Outdated Show resolved Hide resolved
stanleyyconsensys
stanleyyconsensys reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestion on the naming of the key

packages/starknet-snap/locales/en.json Outdated Show resolved Hide resolved
packages/starknet-snap/locales/en.json Outdated Show resolved Hide resolved
packages/starknet-snap/locales/en.json Outdated Show resolved Hide resolved
packages/starknet-snap/locales/en.json Outdated Show resolved Hide resolved
packages/starknet-snap/locales/en.json Outdated Show resolved Hide resolved
packages/starknet-snap/locales/en.json Outdated Show resolved Hide resolved
packages/starknet-snap/locales/en.json Outdated Show resolved Hide resolved
packages/starknet-snap/locales/en.json Outdated Show resolved Hide resolved
packages/starknet-snap/test/src/upgradeAccContract.test.ts Outdated Show resolved Hide resolved
@stanleyyconsensys
Copy link
Collaborator

1 comment not yet fix

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
28.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

stanleyyconsensys
stanleyyconsensys approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanti42 khanti42 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit de42c08 Jan 16, 2025
14 checks passed
@khanti42 khanti42 deleted the feat/sf-761 branch January 16, 2025 13:30
@github-actions github-actions bot mentioned this pull request Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleyyconsensys stanleyyconsensys stanleyyconsensys approved these changes

@Julink-eth Julink-eth Awaiting requested review from Julink-eth Julink-eth is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khanti42 @stanleyyconsensys