chore: wallet-ui send workflow allow return back #468
Conversation
khanti42
requested review from
Julink-eth and
wantedsystem
and removed request for
a team
|
|
packages/wallet-ui/src/components/ui/organism/Header/SendModal/SendModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/molecule/AmountInput/AmountInput.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendModal/SendModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/organism/Header/SendSummaryModal/SendSummaryModal.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/molecule/AmountInput/AmountInput.view.tsx
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/molecule/AmountInput/AmountInput.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/molecule/AmountInput/AmountInput.view.tsx
Outdated
Show resolved
Hide resolved
packages/wallet-ui/src/components/ui/molecule/AmountInput/AmountInput.view.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
In terms of allow return back, which seem okay to me, so i give pass on this PR
but during the testing i found 2 bugs (which also happened in previous UI)
the send modal doesnt do validation and accept "." or "0", and it will have JS error screen if user type "." only
i suggest we can have to a validation on send modal (right now the validation is too simple)
And amount input seem fine, as it responsibly is just blocking non number char and convert USD to ETH
|
Added a task in backlog regarding the validation (sf-804) |
|
|
Based on QA review, this PR introduces functionality that allows users to navigate back from the “Send Summary Modal View” to the “Send View” while retaining the address and value of the transaction. This ensures users can easily update the transaction parameters if needed without starting over.