feat: support txv3 in estimateFee and estimateFeeBulk [SNAP]

[khanti42]

This PR introduces changes related to TRANSACTION_VERSION in preparation for upcoming updates regarding txV3. The primary focus is to set a default value for transactionVersion and ensure consistency across various estimateFee and estimateFeeBulk. No changes in current functionality are introduced in this PR.

Summary of Changes:

• Import Changes:

  • Added import of TRANSACTION_VERSION from constants in several files.

• Code Changes:

  • estimateFee.ts:
    • Added TRANSACTION_VERSION as the default value for transactionVersion if it is not provided in requestParamsObj.
  • estimateFees.ts:
    • Used TRANSACTION_VERSION as the default value for transactionVersion in the estimateFees function.
  • executeTxn.ts:
    • Passed TRANSACTION_VERSION directly to a function.
  • upgradeAccContract.ts:
    • Added TRANSACTION_VERSION as a parameter.
  • constants.ts:
    • Defined TRANSACTION_VERSION and set it to constants.TRANSACTION_VERSION.V2.
  • starknetUtils.ts:
    • Utilized TRANSACTION_VERSION to provide default values in multiple functions.

• Type Changes:

  • Updated transactionVersion type to accept either TRANSACTION_VERSION.V2 or TRANSACTION_VERSION.V3.

• Function Signature Changes:

  • Functions now accept transactionVersion as an optional parameter with default values.

Impact:

• Functional Impact:
  The changes do not alter current behavior. They set up default values and ensure consistent usage of TRANSACTION_VERSION across the codebase.

• Preparatory Work:
  These changes lay the groundwork for handling different transaction versions in future updates.

• Code Consistency:
  Ensures that TRANSACTION_VERSION is consistently used as a single source of truth across the codebase.

No changes to the transaction handling or fee estimation logic are introduced in this PR. This setup will facilitate easier integration of different transaction versions in future developments.

[stanleyyconsensys]

i will highly recommend to change to new api structure if it is possible

[sonarqubecloud]

Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
63.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[stanleyyconsensys]

LGTM