-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PIC algorithm docu #5251
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, mainly misspelled markup.
You can also check the preview yourself at (https://picongpu--5251.org.readthedocs.build/en/5251/models/AOFDTD.html#model-aofdtd)
Haven't read through it yet, I'll have a closer look when the rendering issues are fixed. But as a general direction, we might want to add pictures like the two attached. Both are from the PIConGPU part of the alpaka workshop in October. |
@chillenzer the second (larger) picture is great and fits nicely at the end of @fabidie's new text. We, i.e. you, would just need to update the "current update" step. It should display the continuity equation in differential form and not the current formula. In detail, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It reads well and I especially like the "blob" for macroparticles.
If the picture from @chillenzer is added we might also want to include documentation for the moving window somewhere in the documentation, but this doesn't belong into the PIC algorithm. |
and close Issue #5056 |
d13e535
to
44f7c03
Compare
44f7c03
to
4758620
Compare
ci: no-compile
4758620
to
8f5aa58
Compare
A more detailed description of the PIC algorithm. Let me know whether it is more comprehensive now and if you want to add any information.