update: fix issues in native sol transfer #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvja
reviewed
Dec 16, 2024
| )?; | ||
| let out_user_account = accounts.user_account.clone().unwrap(); | ||
|
|
||
| **solver.lamports.borrow_mut() -= amount_out; |
There was a problem hiding this comment.
since solver account is owned by system program, u need to call system program to transfer just like how you do it in escrow_and_store_intent method.
| )?; | ||
| let out_user_account = accounts.user_account.clone().unwrap(); | ||
|
|
||
| **solver.lamports.borrow_mut() -= amount_out; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run a test, you can simply execute the following command.
Updates on Solana Program
Updates on Test
send_funds_to_userUnclear things
bridge::bridge_transferseems to be updated. But needs help of @alberto