Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf-solana: get timestamp in ns for cf-solana #397

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

dhruvja
Copy link
Collaborator

@dhruvja dhruvja commented Oct 15, 2024

in the consensus_has_expired method, the consensus timestamp is fetched in seconds but added to a trusting period which is in nanoseconds creating a mismatch. So fixing this bug by fetching the consensus timestamp in nanoseconds.

@dhruvja dhruvja requested a review from mina86 October 15, 2024 17:41
common/cf-solana/src/client/impls.rs Show resolved Hide resolved
common/cf-solana/src/client/impls.rs Show resolved Hide resolved
@dhruvja dhruvja enabled auto-merge (squash) October 16, 2024 16:07
@dhruvja dhruvja merged commit ab6ad71 into master Oct 16, 2024
4 checks passed
@dhruvja dhruvja deleted the cf-solana-timestamp branch October 16, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants