cf-solana: add bank hash handling plus some refactoring #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, add DeltaHashProof type which contains all the information that are needed to calculate delta hash. One piece of information in it is the accounts delta hash. As such, this struct together with a trusted bank hash acts as a proof for the accounts delta hash. Secondly, create AccountHashData wrapper for the account_hash_data field of the AccountProof struct. This improves type safety and better encapsulates the account information used in hash calculation. Lastly, fix a few instances where solana-program2 Cargo feature name was used instead of proper solana-program-2.
|
we have to add |
|
An optional dependency is implicitly a feature: https://github.com/ComposableFi/emulated-light-client/blob/mpn/d/common/cf-solana/Cargo.toml#L18 |
oh i see. sounds good then. |
dhruvja
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, add DeltaHashProof type which contains all the information that are needed to calculate delta hash. One piece of information in it is the accounts delta hash. As such, this struct together with a trusted bank hash acts as a proof for the accounts delta hash.
Secondly, create AccountHashData wrapper for the account_hash_data field of the AccountProof struct. This improves type safety and better encapsulates the account information used in hash calculation.
Lastly, fix a few instances where solana-program2 Cargo feature name was used instead of proper solana-program-2.