Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCPBUGS-42396]Add variable reference for resource_requests_limits rules #12987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaojiey
Copy link
Collaborator

@xiaojiey xiaojiey commented Feb 6, 2025

Description:

Add variable reference for resource_requests_limits_in_daemonset, resource_requests_limits_in_deployment and resource_requests_limits_in_statefuleset rules.

@xiaojiey xiaojiey force-pushed the resource-limites-annotations branch 2 times, most recently from 0d3d2e8 to 3fce1c1 Compare February 7, 2025 04:17
@jan-cerny jan-cerny added the OpenShift OpenShift product related. label Feb 7, 2025
@jan-cerny
Copy link
Collaborator

@xiaojiey Please fill in the PR description.

@xiaojiey xiaojiey changed the title Add variable reference for resource_requests_limits rules [WIP]Add variable reference for resource_requests_limits rules Feb 7, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Feb 7, 2025
@xiaojiey xiaojiey force-pushed the resource-limites-annotations branch 3 times, most recently from dbc3c5c to 3de9255 Compare February 8, 2025 07:28
@xiaojiey xiaojiey changed the title [WIP]Add variable reference for resource_requests_limits rules [OCPBUGS-42396]Add variable reference for resource_requests_limits rules Feb 8, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Feb 8, 2025
@xiaojiey xiaojiey force-pushed the resource-limites-annotations branch from 3de9255 to 5359ffa Compare February 8, 2025 07:37
@xiaojiey xiaojiey force-pushed the resource-limites-annotations branch from 5359ffa to e18afde Compare February 8, 2025 07:39
@xiaojiey xiaojiey requested a review from yuumasato February 8, 2025 07:40
Copy link

codeclimate bot commented Feb 8, 2025

Code Climate has analyzed commit e18afde and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants