Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old rules from RHEL 10 profiles #12697

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Dec 10, 2024

Description:

Remove the following rules from RHEL 10

  • no_rsh_trust_files
  • prefer_64bit_os

Rationale:

Prep for RHEL 10.

Review Hints:

Use grep on built profiles or data stream to ensure the rules are gone.

@Mab879 Mab879 added Update Profile Issues or pull requests related to Profiles updates. RHEL10 Red Hat Enterprise Linux 10 product related. labels Dec 10, 2024
@Mab879 Mab879 added this to the 0.1.76 milestone Dec 10, 2024
@Mab879 Mab879 requested a review from a team as a code owner December 10, 2024 18:52
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Dec 10, 2024

Code Climate has analyzed commit d044cbc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Dec 11, 2024
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that these 2 rules aren't present in the built RHEL 10 content.

@jan-cerny jan-cerny merged commit aa76180 into ComplianceAsCode:master Dec 11, 2024
104 of 105 checks passed
@Mab879 Mab879 deleted the clean_up_os_rules branch December 11, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RHEL10 Red Hat Enterprise Linux 10 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants