Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit_immutable_login_uids: remove stig-specific content #12676

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • remove the policy directory as it is no longer needed
  • modify the fixtext not to mention the sample-rules directory

Rationale:

this removes also partially invalid reference to Audit rules directory
@vojtapolasek vojtapolasek added the Update Rule Issues or pull requests related to Rules updates. label Dec 5, 2024
@vojtapolasek vojtapolasek added this to the 0.1.76 milestone Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Dec 5, 2024
@@ -1,23 +0,0 @@
srg_requirement: |-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this shouldn't be in the STIG it should also be removed from SRG GPOS.

controls/srg_gpos/SRG-OS-000057-GPOS-00027.yml:            - audit_immutable_login_uids
controls/srg_gpos/SRG-OS-000058-GPOS-00028.yml:            - audit_immutable_login_uids
controls/srg_gpos/SRG-OS-000462-GPOS-00206.yml:            - audit_immutable_login_uids
controls/srg_gpos/SRG-OS-000059-GPOS-00029.yml:            - audit_immutable_login_uids

@vojtapolasek
Copy link
Collaborator Author

@Mab879 thanks for noticing this, I updated the PR.

Copy link

codeclimate bot commented Dec 9, 2024

Code Climate has analyzed commit 9ce6379 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Dec 10, 2024

Waving the Automatus tests are they for not finding the rule in the data stream or inability to find the audit package in UBI.

@Mab879 Mab879 merged commit f816785 into ComplianceAsCode:master Dec 10, 2024
100 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants