Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule for ubuntu2404 CIS control 4.4.3.2 #12662

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Add rule for ubuntu2404 CIS control 4.4.3.2 #12662

merged 3 commits into from
Dec 4, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Dec 2, 2024

Description:

  • Add rule set_ipv6_loopback_traffic to ubuntu2404 CIS profile
  • Add tests to set_ipv6_loopback_traffic
  • Fix broken regex for Ubuntu 24.04

Notes

mpurg added 3 commits December 2, 2024 13:02
@mpurg
Add tests to rule set_ipv6_loopback_traffic
6f50790
@mpurg
Update ubuntu2404 CIS control 4.4.3.2
0300256
@mpurg
Fix set_ipv6_loopback_traffic SCE for ubuntu2404
a8ce721 
ip6tables output changed from ubuntu2204 to ubuntu2404.
E.g. from `ip6tables -n -v -L INPUT`

- 22.04: `0     0 ACCEPT     all      lo     *       ::/0 ::/0`
- 24.04: `0     0 ACCEPT     0    --  lo     *       ::/0                 ::/0`kj
@mpurg mpurg requested a review from a team as a code owner December 2, 2024 18:06
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 2, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 2, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 2, 2024

Code Climate has analyzed commit a8ce721 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@dodys dodys self-assigned this Dec 4, 2024
@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. Update Profile Issues or pull requests related to Profiles updates. labels Dec 4, 2024
@dodys dodys added this to the 0.1.76 milestone Dec 4, 2024
dodys
dodys approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 35c3b82 into ComplianceAsCode:master Dec 4, 2024
94 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
2 participants
@mpurg @dodys