Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCP/RHCOS assertion files for 4.18 #12634

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

rhmdnd
Copy link
Collaborator

@rhmdnd rhmdnd commented Nov 25, 2024

This makes it so that we can start testing OCP and RHCOS against 4.18
OCP versions.

This makes it so that we can start testing OCP and RHCOS against 4.18
OCP versions.
@rhmdnd rhmdnd added this to the 0.1.76 milestone Nov 25, 2024
@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Nov 25, 2024

This should start getting used when openshift/release#59183 lands.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 25, 2024

Code Climate has analyzed commit 7b1ed9c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@yuumasato
Copy link
Member

yuumasato commented Nov 25, 2024

@rhmdnd Thank you for these files.
I'm curious whether you copied them from 4.17 or gathered them from runs against a 4.18 cluster.

@yuumasato yuumasato added the OpenShift OpenShift product related. label Nov 25, 2024
@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Nov 25, 2024

@rhmdnd Thank you for these files. I'm curious whether you copied them from 4.17 or gathered them from runs against a 4.18 cluster.

Copied from 4.17 testing assertions, just to get us bootstrapped for 4.18. We might need to tweak some assertions depending on the test results.

@yuumasato yuumasato merged commit db04625 into ComplianceAsCode:master Nov 28, 2024
104 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants