Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various openshift assertions #12443

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Update various openshift assertions #12443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3bdfa9
Fix typo in assertion rule id
yuumasato Sep 30, 2024
cf3fb45
Fix result after remediation for cni-conf permissions
yuumasato Sep 30, 2024
9630d28
This rule can occasionally result inconsistent
yuumasato Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/assertions/ocp4/ocp4-pci-dss-4-0-4.15.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ rule_results:
e2e-pci-dss-4-0-kubelet-configure-tls-cert:
default_result: PASS
result_after_remediation: PASS
e3e-pci-dss-4-0-kubelet-configure-tls-cipher-suites-ingresscontroller:
e2e-pci-dss-4-0-kubelet-configure-tls-cipher-suites-ingresscontroller:
default_result: FAIL
result_after_remediation: PASS
e2e-pci-dss-4-0-kubelet-configure-tls-key:
Expand Down
4 changes: 2 additions & 2 deletions tests/assertions/ocp4/ocp4-pci-dss-node-4-0-4.14.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ rule_results:
result_after_remediation: PASS
e2e-pci-dss-node-4-0-master-file-permissions-cni-conf:
default_result: PASS
result_after_remediation: FAIL
result_after_remediation: PASS
e2e-pci-dss-node-4-0-master-file-permissions-controller-manager-kubeconfig:
default_result: PASS
result_after_remediation: PASS
Expand Down Expand Up @@ -544,7 +544,7 @@ rule_results:
result_after_remediation: NOT-APPLICABLE
e2e-pci-dss-node-4-0-worker-file-permissions-cni-conf:
default_result: PASS
result_after_remediation: FAIL
result_after_remediation: PASS
e2e-pci-dss-node-4-0-worker-file-permissions-controller-manager-kubeconfig:
default_result: NOT-APPLICABLE
result_after_remediation: NOT-APPLICABLE
Expand Down
4 changes: 2 additions & 2 deletions tests/assertions/ocp4/ocp4-pci-dss-node-4-0-4.15.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ rule_results:
result_after_remediation: PASS
e2e-pci-dss-node-4-0-master-file-permissions-cni-conf:
default_result: PASS
result_after_remediation: FAIL
result_after_remediation: PASS
e2e-pci-dss-node-4-0-master-file-permissions-controller-manager-kubeconfig:
default_result: PASS
result_after_remediation: PASS
Expand Down Expand Up @@ -544,7 +544,7 @@ rule_results:
result_after_remediation: NOT-APPLICABLE
e2e-pci-dss-node-4-0-worker-file-permissions-cni-conf:
default_result: PASS
result_after_remediation: FAIL
result_after_remediation: PASS
e2e-pci-dss-node-4-0-worker-file-permissions-controller-manager-kubeconfig:
default_result: NOT-APPLICABLE
result_after_remediation: NOT-APPLICABLE
Expand Down
3 changes: 2 additions & 1 deletion tests/assertions/ocp4/ocp4-pci-dss-node-4.12.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,8 @@ rule_results:
e2e-pci-dss-node-master-file-permissions-scheduler-kubeconfig:
default_result: PASS
e2e-pci-dss-node-master-file-permissions-var-log-kube-audit:
default_result: INCONSISTENT
# nodes get INCONSISTENT because of https://bugzilla.redhat.com/show_bug.cgi?id=2001442
default_result: PASS or INCONSISTENT
e2e-pci-dss-node-master-file-permissions-var-log-oauth-audit:
default_result: PASS
e2e-pci-dss-node-master-file-permissions-var-log-ocp-audit:
Expand Down
Loading