Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added remediation and tests for the rule permissions_local_var_log_audit #12360

Conversation

rumch-se
Copy link
Contributor

@rumch-se rumch-se commented Sep 3, 2024

Description:

  • Added remediation and tests to the rule permissions_local_var_log_audit

Rationale:

  • These parts were not available for SLE 12/15 and SLEM

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Sep 3, 2024
Copy link

openshift-ci bot commented Sep 3, 2024

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

github-actions bot commented Sep 3, 2024

Start a new ephemeral environment with changes proposed in this pull request:

sle12 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Sep 3, 2024

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New data stream adds bash remediation for rule 'xccdf_org.ssgproject.content_rule_permissions_local_var_log_audit'.
New data stream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_permissions_local_var_log_audit'.

Copy link

github-actions bot commented Sep 3, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12360
This image was built from commit: c37378a

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12360

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12360 make deploy-local

Copy link

codeclimate bot commented Sep 3, 2024

Code Climate has analyzed commit c37378a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny added Ansible Ansible remediation update. Bash Bash remediation update. SLES SUSE Linux Enterprise Server product related. labels Sep 5, 2024
@jan-cerny jan-cerny added this to the 0.1.75 milestone Sep 5, 2024
@jan-cerny jan-cerny self-assigned this Sep 5, 2024
@jan-cerny jan-cerny merged commit f044487 into ComplianceAsCode:master Sep 5, 2024
87 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ansible Ansible remediation update. Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants