-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMP-2196: Update instructions for ingresscontroller TLS ciphers #12355
Conversation
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Verification pass with ghcr.io/complianceascode/k8scontent:12355:
|
/lgtm |
applications/openshift/kubelet/kubelet_configure_tls_cipher_suites_ingresscontroller/rule.yml
Show resolved
Hide resolved
We can update the instructions so they tell the user what to check for, instead of copy/pasting in a remediation for TLS ciphers, which may not be what they want.
61a946d
to
2a29bac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Code Climate has analyzed commit 2a29bac and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.5% (0.0% change). View more on Code Climate. |
/packit retest-failed |
We can update the instructions so they tell the user what to check for,
instead of copy/pasting in a remediation for TLS ciphers, which may not
be what they want.