Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network mode nm stable #12259

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Aug 1, 2024

Back-port of #12258

@Mab879 Mab879 added the backported-into-stabilization PRs which were cherry-picked during stabilization process. label Aug 1, 2024
@Mab879 Mab879 added this to the 0.1.74 milestone Aug 1, 2024
@Mab879 Mab879 changed the base branch from master to stabilization-v0.1.74 August 1, 2024 19:04
Copy link

github-actions bot commented Aug 1, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Aug 1, 2024

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
OVAL for rule 'xccdf_org.ssgproject.content_rule_sshd_use_approved_ciphers' differs.
--- oval:ssg-sshd_use_approved_ciphers:def:1
+++ oval:ssg-sshd_use_approved_ciphers:def:1
@@ -1,5 +1,3 @@
-criteria AND
-extend_definition oval:ssg-installed_OS_is_FIPS_certified:def:1
 criteria OR
 criteria AND
 extend_definition oval:ssg-sshd_not_required_or_unset:def:1

Copy link

github-actions bot commented Aug 1, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12259
This image was built from commit: e54ac46

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12259

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12259 make deploy-local

Copy link

codeclimate bot commented Aug 1, 2024

Code Climate has analyzed commit e54ac46 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Aug 2, 2024
@jan-cerny jan-cerny merged commit b9f33ae into ComplianceAsCode:stabilization-v0.1.74 Aug 2, 2024
96 of 97 checks passed
@Mab879 Mab879 deleted the fix_network_mode_nm_stable branch August 2, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-into-stabilization PRs which were cherry-picked during stabilization process.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants