-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Notes and Controls for BSI SYS.1.6.A5 - A9 #12247
Add Notes and Controls for BSI SYS.1.6.A5 - A9 #12247
Conversation
Hi @sluetze. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
corresponding consequences for the application run therein. The results of the checking | ||
(1) An application or service to be operated in a container SHOULD be suitable for such operation. | ||
(2) It SHOULD be considered that containers can often be terminated unexpectedly, with | ||
corresponding consequences for the application run therein. (3) The results of the checking | ||
described under SYS.1.6.A3 Secure Use of Containerised IT Systems SHOULD be documented in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could not understand the line
(3) The results of the checking described under SYS.1.6.A3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the original content of BSI which loses a bit of meaning by removing the italics here.
so basically it would be
The results of the checking described under SYS.1.6.A3: "Secure Use of Containerised IT Systems" SHOULD be documented in a comprehensible manner.
I could add the quotation like above to make it more understandable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sluetze I think the quotation marks will help here.
But I don't consider this critical.
Code Climate has analyzed commit f727f10 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
corresponding consequences for the application run therein. The results of the checking | ||
(1) An application or service to be operated in a container SHOULD be suitable for such operation. | ||
(2) It SHOULD be considered that containers can often be terminated unexpectedly, with | ||
corresponding consequences for the application run therein. (3) The results of the checking | ||
described under SYS.1.6.A3 Secure Use of Containerised IT Systems SHOULD be documented in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sluetze I think the quotation marks will help here.
But I don't consider this critical.
The quotation marks on the requirement title can be added later if it seems relevant. The testing farm error is unrelated, merging. |
Description:
Notes / Rules for BSI APP4.4.A19
Rationale:
Rationale:
As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.
Fixes
Review Hints:
nothing special here, we don't have new rules. We only link some already existing ones and add descriptions.