Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33948: Clairfy encryption ciphers available for use in OpenShift #12089

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

rhmdnd
Copy link
Collaborator

@rhmdnd rhmdnd commented Jun 24, 2024

Previously, we were only advertising aescbc, even though the rule checks
for aesgcm, too. This commit updates the instruction so that it is
consistent with what OpenShift supports.

@rhmdnd
Copy link
Collaborator Author

rhmdnd commented Jun 24, 2024

/jira-refresh

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Jun 24, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12089
This image was built from commit: eeacc49

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12089

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12089 make deploy-local

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhmdnd Could you please also update the description, rationale and ocil_clause with mention of aesgcm too?

@yuumasato yuumasato self-assigned this Jun 25, 2024
Previously, we were only advertising aescbc, even though the rule checks
for aesgcm, too. This commit updates the instruction so that it is
consistent with what OpenShift supports.
@rhmdnd rhmdnd requested a review from yuumasato June 25, 2024 20:12
Copy link

codeclimate bot commented Jun 25, 2024

Code Climate has analyzed commit eeacc49 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@yuumasato yuumasato added this to the 0.1.74 milestone Jun 26, 2024
@yuumasato yuumasato added the OpenShift OpenShift product related. label Jun 26, 2024
@yuumasato yuumasato merged commit c45d02a into ComplianceAsCode:master Jun 26, 2024
92 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants