-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dconf profiles in bash remediation of dconf rules on Ubuntu #12016
Enable dconf profiles in bash remediation of dconf rules on Ubuntu #12016
Conversation
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
/packit build |
3c0df2f
to
4080db5
Compare
4080db5
to
a85fe6c
Compare
b7c822c
to
e0db31f
Compare
Created new macro `bash_enable_dconf_user_profile`.
Several dconf rules check for the existence of dconf user profiles by extending the oval definition with `enable_dconf_user_profile`, but do not create the profiles in their remediations, thus always fail on Ubuntu because the dconf profiles do not exist by default.
749987d
to
7e2e491
Compare
@marcusburghardt @jan-cerny could you have a look at the test |
It should be fixed. I restarted the failed job now. |
The rule is no longer needed because the individual dconf rules implement the check and remediation for enabling the dconf profiles.
7e2e491
to
c2bc84a
Compare
Code Climate has analyzed commit c2bc84a and detected 12 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
It still seems to be failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Description:
enable_dconf_user_profile
.bash_enable_dconf_user_profile
for enabling dconf profiles.Rationale:
enable_dconf_user_profile
, but did not create the dconf profiles in their remediations, thus always failing on Ubuntu because the dconf profiles do not exist by default.