-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and reorganize CMakeLists.txt file #12000
Review and reorganize CMakeLists.txt file #12000
Conversation
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
/packit retest-failed |
/packit build |
@marcusburghardt Please have a look into the failing test
|
I could not reproduce it locally. I need to investigate it more in a VM similar to CI tests. Moved to Draft for now. |
5d2580a
to
599ae01
Compare
For better readability.
Also moved some conditionals used in build time after the definition of variables.
Also ordred the python modules.
The options were not grouped and it was difficult to review. Once they were grouped it was noticed some options not being showing in output messages. They were included.
Thanks @jan-cerny for the hints.
532d3ca
to
86a7602
Compare
The set(Python_ADDITIONAL_VERSIONS 3 2) line was accidentaly moved after find_package(PythonInterp REQUIRED), impacting in the value of PYTHON_EXECUTABLE variable. It was noticed in a CI test for CentOS Stream8 where the "/usr/bin/python3" was still poiting to "/usr/bin/python3.6" while "/usr/bin/python3.11" was already present and this impacted the detection of installed Python modules. Few other improvements in readability were made in this commit.
86a7602
to
fd7d236
Compare
I believe the issue is now fixed in the last commit. Just waiting the CI tests to confirm. |
Code Climate has analyzed commit fd7d236 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have run make package_source
, I copied the generated bz2 file to a new directory in /tmp
and I extracted it there and I have built rhel9
product there.
Also, I have checked the CMake output in some of the "static-checks" GitHub CI jobs.
Description:
This PR is improving the readability of
CMakeLists.txt
basically by:Rationale:
Improve readability of
CMakeLists.txt
file to make easier to work on it.Review Hints:
Besides the readability of the file and some changes in the output, the test is basically building the products and confirming everything that it still working as expected.