Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grub2_bootloader_argument to check /etc/default/grub.d on Ubuntu #11612

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Feb 21, 2024

Description:

  • Modify OVAL in grub2_bootloader_argument template to also check the configs in /etc/default/grub.d on Ubuntu
  • Add and fix ubuntu tests

Rationale:

  • The old OVAL checked the compiled config in /boot and the config in /etc/default/grub, but not the configs /etc/default/grub.d/*.cfg, which are also sourced when running grub-mkconfig.
  • Fixes https://bugs.launchpad.net/usg/+bug/2053240

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 21, 2024
Copy link

openshift-ci bot commented Feb 21, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11612

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11612

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11612 make deploy-local

@dodys dodys requested a review from a team February 21, 2024 15:39
@dodys dodys self-assigned this Feb 21, 2024
@dodys dodys added Ubuntu Ubuntu product related. ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Feb 21, 2024
Copy link

codeclimate bot commented Feb 21, 2024

Code Climate has analyzed commit b0e1885 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.1% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 9c496b1 into ComplianceAsCode:master Feb 23, 2024
44 checks passed
@Mab879 Mab879 added the Update Template Issues or pull requests related to Templates updates. label May 16, 2024
@Mab879 Mab879 added this to the 0.1.73 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Template Issues or pull requests related to Templates updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants