Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_firewalld_default_zone: add a bash remediation #11251

Conversation

nightmared
Copy link
Contributor

Hello, this bash remediation for set_firewalld_default_zone switches all the network zones to the drop firewalld zone.
Note that this may be dangerous on a running system, as one could lock oneself out of its own system.

I'm more than open to discussions on whether that should be dropped (in which case the whole OVAL check + bash remediation) could probably be replaced by a simple call to the line_in_file template.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 6, 2023
Copy link

openshift-ci bot commented Nov 6, 2023

Hi @nightmared. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

github-actions bot commented Nov 6, 2023

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Nov 6, 2023

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New data stream adds bash remediation for rule 'xccdf_org.ssgproject.content_rule_set_firewalld_default_zone'.

@Mab879 Mab879 added the Bash Bash remediation update. label Nov 6, 2023
@Mab879 Mab879 added this to the 0.1.71 milestone Nov 6, 2023
@Mab879 Mab879 self-assigned this Nov 6, 2023
@nightmared nightmared force-pushed the add_bash_remediation_set_firewalld_default_zone branch from cb755c1 to e45b198 Compare November 6, 2023 17:37
Copy link

codeclimate bot commented Nov 6, 2023

Code Climate has analyzed commit e45b198 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5%.

View more on Code Climate.

@nightmared
Copy link
Contributor Author

As is shown in #11250 (comment), work is needed to decide a better shape for this feature.
I will close this for now, and open a new PR when a sane behaviour has been agreed upon in that discussion.

Sorry for the spam :/

@nightmared nightmared closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash Bash remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants