-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stabilization phase description to developers guide #11234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just style guide things.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mildas . Just take a look at Matthew's comments.
## Duration | ||
Current duration is set to **2 weeks**. This duration is approximate. Complications such as newly discovered major issues during this period might slightly prolong it. | ||
|
||
The duration is tied to release cadence. The more time between release, the more time for stabilization is needed. Thus, the current 2 weeks stabilization is for release every 2 months. However, stabilization period does not affect release cadence. Next release date will be the same as there would not be any prolongation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I agree with this sentence The more time between release, the more time for stabilization is needed.
but it should be reviewed in the future because along the time we can also optimize the stabilization phase and therefore the cadence should have minimal impact on time demanded for stabilization phase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, with optimized stabilization phase it will take less time. But even then the highlighted sentence will be true. For example we can get to 1 week long stabilization for release every 2 months, but if we change cadence to 3 months, the stabilization will need to be slightly prolonged as the chance of problems will be higher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you reference this new file in https://github.com/ComplianceAsCode/content/blob/master/docs/release_process.md, please?
7391068
to
fc9bedc
Compare
fc9bedc
to
2f679ba
Compare
Thanks for the feedback. I've addressed style guide issues and added reference to Release process guide. |
Code Climate has analyzed commit 2f679ba and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.4%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description:
Initially, the description was published as discussion.
Rationale:
Stabilization phase is performed before every release. It is defined process that should be described in developers guide so anyone can read about it.