Fix for rsyslog_logfiles_attributes_modify remediation for Ubuntu #11225
Conversation
Ignoring pass tests for now since the platform-specifc user/group/perms are hardcoded.
Ubuntu ships with mawk which doesn't support gawk's gensub function. sed-based approach is used instead to extract rsyslog config files defined in the Include() statements.
|
Hi @mpurg. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
dodys
added
Ubuntu
shared/templates/rsyslog_logfiles_attributes_modify/bash.template
Outdated
Show resolved
Hide resolved
- switched to unified sed approach on all platforms - fixed too inclusive regex - switched to case-insensitive grep searches since rsyslog parms are insensitive
|
Code Climate has analyzed commit c3d588f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.4%. View more on Code Climate. |
|
@Mab879 @marcusburghardt not sure if Jan is on leave or something, but if you could also approve this PR from your side, it would be great :) |
|
/packit test |
Description:
Fix for remediation for rule
rsyslog_logfiles_attributes_modifyon Ubuntu platforms.Rationale:
Ubuntu ships with mawk which doesn't support gawk's gensub function.
Instead, a sed-based approach is used to extract rsyslog config files which are defined in Include() statements.