Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rpm python package SLE15 Automatus docker file #11212

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Oct 20, 2023

Description:

  • python-rpm -> python3-rpm in the SLES15 Automatus Docker file

Rationale:

So the Automatus container builds.

@Mab879 Mab879 added Test Suite Update in Test Suite. SLES SUSE Linux Enterprise Server product related. labels Oct 20, 2023
@Mab879 Mab879 added this to the 0.1.71 milestone Oct 20, 2023
@Mab879 Mab879 requested a review from a team October 20, 2023 00:37
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Oct 20, 2023

Code Climate has analyzed commit 40ba9ed and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 57.0%.

View more on Code Climate.

Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine to me. Before this change building a container image using the podman build -f test_suite-sle15 fails and after this change the image builds successfully.

@ComplianceAsCode/suse-maintainers Please review this PR.

Copy link
Contributor

@teacup-on-rockingchair teacup-on-rockingchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help @Mab879

@teacup-on-rockingchair teacup-on-rockingchair merged commit 693d6a5 into ComplianceAsCode:master Nov 2, 2023
34 checks passed
@Mab879 Mab879 deleted the fix_sle15_automatus branch November 2, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SLES SUSE Linux Enterprise Server product related. Test Suite Update in Test Suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants