Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken docs link in the Compliance Operator bundle #646

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Jan 13, 2025

The old link pointed to a section of the compliance operator documentation before it was overhauled and reorganized.

This commit updates the documentation reference in the bundle so it points to the right document, and doesn't return a 404.

@rhmdnd rhmdnd requested a review from sheriff-rh January 13, 2025 22:10
@rhmdnd rhmdnd requested review from yuumasato and Vincent056 and removed request for mrogers950 January 13, 2025 22:11
@rhmdnd rhmdnd changed the title FIx broken docs link in the Compliance Operator bundle Fix broken docs link in the Compliance Operator bundle Jan 13, 2025
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:646-410eb28ad7378ad207d44c64430df3e9da3438e1

Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:646-c8ff86519ac219815d40ed6b78b5175ac5cff827

@xiaojiey
Copy link
Collaborator

/label qe-approved

@sheriff-rh
Copy link
Collaborator

LGTM, thank you!

@yuumasato yuumasato added this to the 1.7.0 milestone Jan 15, 2025
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are others occurrences in test data streams, do we care about those?
grep -r 'latest.*compliance-operator-understanding.html':

  • tests/data/ssg-ocp4-ds-suppressed.xml
  • images/testcontent/new_kubeletconfig/ssg-ocp4-ds.xml

@rhmdnd
Copy link
Author

rhmdnd commented Jan 16, 2025

The old link pointed to a section of the compliance operator documentation before it was overhauled and reorganized.

This commit updates the documentation reference in the bundle so it points to the right document, and doesn't return a 404.
@rhmdnd
Copy link
Author

rhmdnd commented Jan 16, 2025

There are others occurrences in test data streams, do we care about those? grep -r 'latest.*compliance-operator-understanding.html':

* `tests/data/ssg-ocp4-ds-suppressed.xml`

* `images/testcontent/new_kubeletconfig/ssg-ocp4-ds.xml`

Fixed

@rhmdnd rhmdnd force-pushed the fix-bundle-doc-link branch from c8ff865 to 6b16c6a Compare January 16, 2025 14:24
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:646-6b16c6afcc76a0074169d13943c758ddd54e1431

Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuumasato
Copy link
Member

/test e2e-aws-parallel

@openshift-merge-bot openshift-merge-bot bot merged commit 8b87173 into master Jan 16, 2025
34 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the fix-bundle-doc-link branch January 16, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants