Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Debounce Extension to DispatcherTimer #3004

Merged
merged 3 commits into from
Sep 13, 2019

Conversation

michael-hawker
Copy link
Member

For rate-limiting UI events (like triggering on typing)
For use in Graph Controls later

Issue: #2989

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

It's hard to know when the user is typing when to execute a search query.

What is the new behavior?

By wrapping typed event callback in debounce method, it's easy to only query a remote server after the user has delayed in their typing.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@michael-hawker michael-hawker merged commit e59860e into master Sep 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the mhawker/dispatcher-debounce branch September 13, 2019 22:34
@pedasmith
Copy link

The documentation for this doesn't seem to have made it into https://docs.microsoft.com/en-us/dotnet/api/microsoft.toolkit.uwp.ui.extensions?view=win-comm-toolkit-dotnet-stable

@michael-hawker
Copy link
Member Author

michael-hawker commented Apr 6, 2020

@pedasmith yeah, we had an issue updating the .NET docs in our last release. We just sorted out other issues with our doc building, so that's the next doc issue on my list to resolve still. Sorry for the trouble, the docs are just generated from the XML comments here, so they're still accurate.

I opened an Issue on our Doc Repo here for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants