Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#199) async query in table controller #236

Merged
merged 15 commits into from
Jan 31, 2025

Conversation

adrianhall
Copy link
Collaborator

  • Devolved OData manipulation for better async support.
  • Updated tests to support async operations.
  • Disabled client-side evaluation.

@adrianhall adrianhall added this to the 9.0.0 milestone Jan 30, 2025
@adrianhall adrianhall requested a review from Copilot January 30, 2025 17:52
@adrianhall adrianhall self-assigned this Jan 30, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 37 out of 55 changed files in this pull request and generated 1 comment.

Files not reviewed (18)
  • docs/public/404.html: Language not supported
  • docs/public/categories/index.html: Language not supported
  • docs/public/css/chroma-auto.css: Language not supported
  • docs/public/css/format-print.css: Language not supported
  • docs/public/css/print.css: Language not supported
  • docs/public/css/swagger.css: Language not supported
  • docs/public/css/theme-auto.css: Language not supported
  • docs/public/css/variant.css: Language not supported
  • docs/public/in-depth/client/auth/index.html: Language not supported
  • docs/public/in-depth/client/index.html: Language not supported
  • docs/public/in-depth/client/index.xml: Language not supported
  • docs/public/in-depth/client/maui-aot-support/index.html: Language not supported
  • docs/public/in-depth/client/online-operations/index.html: Language not supported
  • docs/public/in-depth/index.html: Language not supported
  • docs/public/in-depth/server/databases/azuresql/index.html: Language not supported
  • docs/public/in-depth/server/databases/cosmos/index.html: Language not supported
  • docs/public/in-depth/server/databases/in-memory/index.html: Language not supported
  • docs/public/in-depth/server/databases/index.html: Language not supported

@adrianhall
Copy link
Collaborator Author

@richard-einfinity - would love your review on this - more from a "does it work with your Cosmos service implementation"

@adrianhall adrianhall linked an issue Jan 30, 2025 that may be closed by this pull request
3 tasks
@richard-einfinity
Copy link
Contributor

Hi @adrianhall, yes this is more or less what I've got at the moment but with a bit more finesse :)

One thing, should the OData validation settings be expanded to validate the supported OData options. With this implementation the non supported options will be ignored anyway.

  ODataValidationSettings validationSettings = new()
  {
      MaxTop = Options.MaxTop,
      AllowedQueryOptions = AllowedQueryOptions.Select |
      AllowedQueryOptions.Filter |
      AllowedQueryOptions.OrderBy |
      AllowedQueryOptions.Skip |
      AllowedQueryOptions.Top |
      AllowedQueryOptions.Count

  };

When this is merged in I can drop my custom Controller and repository implementations. I'll rebase my branch and get it up onto my public repository. It's still a work in progress, I think there's about a hundred warnings to do with xml documentation to work through. I got a few more options to expand out and some error handling. But your thoughts would be much appreciated if you get the chance.

Cheers

Rich

@richard-einfinity
Copy link
Contributor

@adrianhall current cosmos work in progress here. https://github.com/richard-einfinity/Datasync/tree/Feature/Cosmos

@adrianhall adrianhall merged commit a738891 into CommunityToolkit:main Jan 31, 2025
4 checks passed
@adrianhall adrianhall deleted the issues/199 branch January 31, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move TableController.Query to async operation
2 participants