Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#211) Client: Fix wrong EntityType in OperationsQueue when using Lazy Loading Proxies #212

Merged

Conversation

david1995
Copy link
Contributor

Replaced some GetType() calls with getting the entity type via metadata.
I have added a test for this scenario.

This should fix issue #211.

@adrianhall adrianhall self-requested a review January 21, 2025 19:37
@adrianhall
Copy link
Collaborator

Thank you for the contribution. I will do the live tests after I've finished off.

Should we set up an explicit "related entities" test within the client to ensure that the expected behavior works? I feel it's a good idea (can be done as a second PR).

@adrianhall adrianhall self-assigned this Jan 21, 2025
@adrianhall adrianhall added this to the 9.0.0 milestone Jan 21, 2025
@adrianhall adrianhall merged commit 49bd9d1 into CommunityToolkit:main Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client: Wrong entity type used for DatasyncOperationsQueue when using EF Core dynamic proxies
2 participants