Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup partial armor implementation #3623

Open
wants to merge 4 commits into
base: Development
Choose a base branch
from
Open

Cleanup partial armor implementation #3623

wants to merge 4 commits into from

Conversation

AluminumAlman
Copy link
Contributor

@AluminumAlman AluminumAlman commented Jan 2, 2025 •
edited
Loading

Changes

  • Will cleanup the current implementation of partial armor;
  • Will fix the issue of secondary damage breaking if an exception occurs while applying secondary damages.

References

Reasoning

  • Current implementation of partial armor has too many edge cases, none of which were luckily hit, for example, if sharp and blunt armor multipliers have different multipliers, the multiplier that was last defined would be used.

Testing

  • Compiles without warnings;
  • Game runs without errors;
  • Playtested a colony.

@AluminumAlman AluminumAlman changed the title Initial cleanup of partial armor implementation Cleanup partial armor implementation Jan 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12586359102.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jan 2, 2025
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12843315924.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12843663960.zip

@AluminumAlman AluminumAlman marked this pull request as ready for review January 18, 2025 11:47
@AluminumAlman AluminumAlman requested review from a team as code owners January 18, 2025 11:47
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12856614400.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AluminumAlman