Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE when riposte kills opponents #3615

Merged

Conversation

masakitenchi
Copy link
Contributor

Changes

Fix old transpiler code which causes NRE when riposte kills its opponents

References

Alternatives

Let it be...

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors

@masakitenchi masakitenchi requested review from a team as code owners December 28, 2024 01:14
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12522472475.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Dec 28, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12852664824.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue. Tested by cranking up the damage of the plasma sword, giving it to a level 20 melee, and letting a level 0 melee punch at him til he riposte'd.

@N7Huntsman N7Huntsman merged commit 1ee98e4 into CombatExtended-Continued:Development Jan 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]:NRE when riposte kills attacker
3 participants