Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert MH patches to ABF patches #3564

Merged
merged 13 commits into from
Dec 6, 2024
Merged

Convert MH patches to ABF patches #3564

merged 13 commits into from
Dec 6, 2024

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Nov 22, 2024 •
edited
Loading

Additions

  • Patch the ABF Synstructs series, based on the old MH Androids series.
  • Add a patch for the ABF Utilities Synstruct mod.
    • Adds a couple new types of synstructs that have been patched along similar lines to the existing bots.

Changes

  • Remove outdated patches for several 'Android' modules that do not have 1.5 versions:
    • Android Tiers SM7 Overhaul
    • Android TX Series

Reasoning

  • ABF is replacing MH, with a lot of the patching just coming down to updating the defNames.
    • Someone made a 1.5 update for the Android Tiers base mod based on the old Atlas version, and it has several thousand subs. Could update to support this, but the mod is essentially a combination of the entire series and would require a fair bit of work. If anyone cares enough to ask, maybe we reverse the patch.
  • A few of these submods haven't even been updated to 1.4, and I couldn't find versions for 1.5 on the workshop. May as well trim out the obsolete patches.

Alternatives

  • Could leave it all as is, I guess.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners November 22, 2024 08:26
@N7Huntsman N7Huntsman marked this pull request as draft November 22, 2024 08:26
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11969048588.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 22, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11969556942.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11983117530.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12042113039.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12090882206.zip

@N7Huntsman N7Huntsman changed the title Convert MH patches to ABF patches (wip) Convert MH patches to ABF patches Nov 29, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12093489563.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12176357921.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12176417034.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12176444047.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12176481603.zip

@N7Huntsman N7Huntsman marked this pull request as ready for review December 5, 2024 09:06
Airomeda
Airomeda approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@Airomeda Airomeda self-requested a review December 5, 2024 09:47
Airomeda
Airomeda requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo with LoadFolders, resulting in patch not applied

LoadFolders.xml Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12188328026.zip

@N7Huntsman N7Huntsman requested a review from Airomeda December 5, 2024 21:29
@N7Huntsman N7Huntsman merged commit e73c7d9 into Development Dec 6, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the ABF-Patches branch December 6, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Airomeda Airomeda Airomeda approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N7Huntsman @Airomeda