CIWS v2 #3534

MaxDorob · 2024-11-05T07:46:34Z

Additions

Describe new functionality added by your code

Multi verb turret
CIWS turret
Projectile, skyfaller CIWS verb (and verb that targets things with CompCIWSTarget childs)
Trajectory workers (mostly necessary because we need to know the trajectory before we launch projectile)
- LerpedTrajectoryWorker - original trajectory
- BallisticsTrajectoryWorker - non-lerped trajectory worker, mostly moved code from ProjectileCE
- SmartRocketTrajectoryWorker - trajectory worker for projectile that chase target
ProjectilePropertiesCE
- speedGain (float)
- collideDistance and impactChance (float, used for CIWS projectile)
- CIWSVersion (ThingDef, used to swap projectiles when CIWS verbs used)
- trajectoryWorker (Type, if not specified LerpedTrajectoryWorker is used (BallisticsTrajectoryWorker if lerpPosition false))

Changes

Describe adjustments to existing features made in this merge

Changed some base verb methods
Moved some trajectory work to worker class (because we need to know trajectory before launch)

References

ToDo

Testing

Check tests you have performed:

Compiles without warnings
Game runs without errors
Playtested a colony (tested few variants of CIWS and other weapons)

Examples

Turrets should use projectiles with thingClass ProjectileCE_CIWS.
You can specify CIWS version in def with CIWSVersion node like this:

<ThingDef Name="Bullet_8x35mmCharged" ParentName="Base8x35mmChargedBullet">
		<defName>Bullet_8x35mmCharged</defName>
		<label>8x35mm Charged bullet</label>
		<projectile Class="CombatExtended.ProjectilePropertiesCE">
      <CIWSVersion>Bullet_8x35mmChargedCIWS</CIWSVersion>
			<damageAmountBase>19</damageAmountBase>
			<secondaryDamage>
				<li>
					<def>Bomb_Secondary</def>
					<amount>6</amount>
				</li>
			</secondaryDamage>
			<armorPenetrationSharp>16</armorPenetrationSharp>
			<armorPenetrationBlunt>57.6</armorPenetrationBlunt>
		</projectile>
	</ThingDef>
	...

  <ThingDef Name="Bullet_8x35mmChargedCIWS" ParentName="Base8x35mmChargedBullet">
    <defName>Bullet_8x35mmChargedCIWS</defName>
    <thingClass>CombatExtended.ProjectileCE_CIWS</thingClass>
    <label>8x35mm Charged bullet</label>
    <projectile Class="CombatExtended.ProjectilePropertiesCE">
      <damageAmountBase>19</damageAmountBase>
      <secondaryDamage>
        <li>
          <def>Bomb_Secondary</def>
          <amount>6</amount>
        </li>
      </secondaryDamage>
      <armorPenetrationSharp>16</armorPenetrationSharp>
      <armorPenetrationBlunt>57.6</armorPenetrationBlunt>
      <trajectoryWorker>CombatExtended.LerpedTrajectoryWorker_ExactPosDrawing</trajectoryWorker>
    </projectile>
  </ThingDef>

CIWS must use Building_CIWS_CE as thingClass

<!--=============== Blaster CIWS ===============-->

	<ThingDef ParentName="TurretAutoBase">
		<defName>CIWS_Blaster</defName>
    <thingClass>CombatExtended.Building_CIWS_CE</thingClass>
		<label>charge blaster CIWS</label>
		<constructionSkillPrerequisite>8</constructionSkillPrerequisite>
		<graphicData>
			<texPath>Things/Building/Turrets/MachineGunBase</texPath>
			<shadowData>
				<volume>(0.27,0.25,0.27)</volume>
				<offset>(0,0,0)</offset>
			</shadowData>
		</graphicData>
		<uiIconPath>UI/Icons/Turrets/ChargeBlaster_uiIcon</uiIconPath>
		<statBases>
			<WorkToBuild>23000</WorkToBuild>
			<MaxHitPoints>150</MaxHitPoints>
			<Mass>20</Mass>
			<Bulk>25</Bulk>
			<AimingAccuracy>0.75</AimingAccuracy>
			<ShootingAccuracyTurret>1.25</ShootingAccuracyTurret>
			<NightVisionEfficiency>0.5</NightVisionEfficiency>
		</statBases>
		<techLevel>Spacer</techLevel>
		<comps>
			<li Class="CompProperties_Power">
				<compClass>CompPowerTrader</compClass>
				<basePowerConsumption>400</basePowerConsumption>
			</li>
		</comps>
		<description>Automatic turret equipped with a charge blaster.</description>
		<costList>
			<Steel>125</Steel>
			<Plasteel>40</Plasteel>
			<ComponentIndustrial>6</ComponentIndustrial>
			<ComponentSpacer>1</ComponentSpacer>
		</costList>
		<building>
			<turretGunDef>Gun_CIWSBlasterTurret</turretGunDef>
			<ai_combatDangerous>true</ai_combatDangerous>
		</building>
		<designatorDropdown>CE_AutoTurrets</designatorDropdown>
		<placeWorkers>
			<li>PlaceWorker_TurretTop</li>
			<li>PlaceWorker_ShowTurretRadius</li>
		</placeWorkers>
		<researchPrerequisites>
			<li>CE_ChargeTurret</li>
		</researchPrerequisites>
		<minifiedDef>MinifiedThing</minifiedDef>
	</ThingDef>

Gun of such CIWS may have few attack verbs unlike usual turret.
Usual attack verb (non CIWS) must be specified first (otherwise turret may ignore it).
Also you may specify CompVerbDisabler in comps to make CIWS disablable.
Example of such gun:

	<ThingDef ParentName="BaseAutoTurretGun">
		<defName>Gun_CIWSBlasterTurret</defName>
		<label>blaster turret gun</label>
		<graphicData>
			<texPath>Things/Building/Turrets/BlasterTurret_Top</texPath>
			<graphicClass>Graphic_Single</graphicClass>
		</graphicData>
		<description>Charge blaster attached to a turret mount.</description>
		<soundInteract>Interact_ChargeRifle</soundInteract>
		<statBases>
			<SightsEfficiency>1</SightsEfficiency>
			<ShotSpread>0.06</ShotSpread>
			<SwayFactor>0.86</SwayFactor>
			<RangedWeapon_Cooldown>0.36</RangedWeapon_Cooldown>
			<Mass>10</Mass>
		</statBases>
		<verbs>
			<li Class="CombatExtended.VerbPropertiesCE">
				<recoilAmount>0.90</recoilAmount>
				<verbClass>CombatExtended.Verb_ShootCE</verbClass>
				<hasStandardCommand>true</hasStandardCommand>
				<defaultProjectile>Bullet_8x35mmCharged</defaultProjectile>
				<warmupTime>1.3</warmupTime>
				<range>55</range>
				<ticksBetweenBurstShots>5</ticksBetweenBurstShots>
				<burstShotCount>10</burstShotCount>
				<soundCast>Shot_ChargeBlaster</soundCast>
				<soundCastTail>GunTail_Heavy</soundCastTail>
				<muzzleFlashScale>9</muzzleFlashScale>
				<recoilPattern>Mounted</recoilPattern>
			</li>
      <li Class="CombatExtended.VerbProperties_CIWSProjectile">
        <verbClass>CombatExtended.VerbCIWSProjectile</verbClass>
        <recoilAmount>0.90</recoilAmount>
        <hasStandardCommand>true</hasStandardCommand>
        <defaultProjectile>Bullet_8x35mmCharged</defaultProjectile>
        <warmupTime>0.4</warmupTime>
        <range>105</range>
        <ticksBetweenBurstShots>5</ticksBetweenBurstShots>
        <burstShotCount>10</burstShotCount>
        <soundCast>Shot_ChargeBlaster</soundCast>
        <soundCastTail>GunTail_Heavy</soundCastTail>
        <muzzleFlashScale>9</muzzleFlashScale>
        <recoilPattern>Mounted</recoilPattern>
        <holdFireLabel>HoldCloseInProjectilesFire</holdFireLabel>
        <holdFireDesc>HoldCloseInProjectilesFireDesc</holdFireDesc>
      </li>
      <li Class="CombatExtended.VerbProperties_CIWSSkyfaller">
        <verbClass>CombatExtended.VerbCIWSSkyfaller</verbClass>
        <recoilAmount>0.90</recoilAmount>
        <hasStandardCommand>true</hasStandardCommand>
        <defaultProjectile>Bullet_8x35mmCharged</defaultProjectile>
        <warmupTime>0.4</warmupTime>
        <range>105</range>
        <ticksBetweenBurstShots>5</ticksBetweenBurstShots>
        <burstShotCount>10</burstShotCount>
        <soundCast>Shot_ChargeBlaster</soundCast>
        <soundCastTail>GunTail_Heavy</soundCastTail>
        <muzzleFlashScale>9</muzzleFlashScale>
        <recoilPattern>Mounted</recoilPattern>
        <holdFireLabel>HoldCloseInSkyfallersFire</holdFireLabel>
      </li>
		</verbs>
		<comps>
			<li Class="CombatExtended.CompProperties_AmmoUser">
				<magazineSize>100</magazineSize>
				<reloadTime>7.8</reloadTime>
				<ammoSet>AmmoSet_8x35mmCharged</ammoSet>
			</li>
      <li>
        <compClass>CombatExtended.CompVerbDisabler</compClass>
      </li>
		</comps>
	</ThingDef>

Example of smart rocket, that use specific trajectory worker

	<ThingDef Name="Base50mmRocket" ParentName="BaseExplosiveBullet" Abstract="true">
		...
		<projectile Class="CombatExtended.ProjectilePropertiesCE">
			...
      <ballisticCoefficient>1.0</ballisticCoefficient>
      <mass>1.0</mass>
      <diameter>2</diameter>
		</projectile>
	</ThingDef>

	<ThingDef ParentName="Base50mmRocket">
		<defName>Bullet_50mmRocket_HE</defName>
		...
		<projectile Class="CombatExtended.ProjectilePropertiesCE">
                 ...
      <CIWSVersion>Bullet_50mmRocket_HE_CIWS</CIWSVersion>
		</projectile>
		...
	</ThingDef>

  <ThingDef ParentName="Base50mmRocket">
    <defName>Bullet_50mmRocket_HE_CIWS</defName>
    <thingClass>CombatExtended.ProjectileCE_CIWS</thingClass>
    <label>50mm rocket (HE)</label>
    <graphicData>
      <texPath>Things/Projectile/Rocket/70mmAPKWS</texPath>
      <graphicClass>Graphic_Single</graphicClass>
      <drawSize>0.70</drawSize>
    </graphicData>
    <projectile Class="CombatExtended.ProjectilePropertiesCE">
      <damageDef>Bomb</damageDef>
      <damageAmountBase>147</damageAmountBase>
      <explosionRadius>0</explosionRadius>
      <trajectoryWorker>CombatExtended.SmartRocketTrajectoryWorker</trajectoryWorker>
      <speed>120</speed>
      <speedGain>32</speedGain>
    </projectile>
    ...
  </ThingDef>
  
  <ThingDef>
     <defName>Turret_RocketswarmLauncher</defName>
     <thingClass>CombatExtended.Building_CIWS_CE</thingClass>
     ...
  </ThingDef>

…MaxDorob/HAETAE_CIWS)

Count warmup time when trying to predict position Not tested yet (as well as everything else about CIWS)

MultiVerb turret

github-actions · 2024-11-30T14:09:03Z

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12097015705.zip

github-actions · 2024-11-30T14:51:06Z

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12097281167.zip

github-actions · 2024-11-30T15:23:09Z

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12097480056.zip

github-actions · 2024-11-30T15:28:12Z

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12097511410.zip

mszabo-wikia · 2024-11-29T19:37:28Z

Source/CombatExtended/CombatExtended/Projectiles/TrajectoryWorkers/BaseTrajectoryWorker.cs

+            float speedGain,
+            float maxSpeed,
+            int flightTicks)
+        {


suggestion: It might simplify things to pack all these parameters into a ref struct and pass that around instead. Right now the full parameter list has to be spelled out in a lot of places.

Source/CombatExtended/CombatExtended/Comps/CompCIWSImpactHandler_Skyfaller.cs

mszabo-wikia · 2024-11-29T19:42:03Z

Source/CombatExtended/CombatExtended/Comps/CompCIWSImpactHandler_Skyfaller.cs

+        private Thing TryDropThing(Thing thing, Map map, IntVec3 position)
+        {
+            var contents = (parent as IActiveDropPod)?.Contents;
+            Rot4 rot = (contents?.setRotation != null) ? contents.setRotation.Value : Rot4.North;


We could return early if contents are null here and spare a lot of null checks down the line

Rimworld ActiveDropPod.OpenPod works the same way, so is it really worth it?

I think it's worth it since this code will now live in CE, so simplifying things will make life easier for future us.

Source/CombatExtended/CombatExtended/Verbs/Verb_LaunchProjectileCE.cs

Source/CombatExtended/CombatExtended/Verbs/VerbCIWS.cs

Source/CombatExtended/CombatExtended/Comps/CompCIWSTarget.cs

Source/CombatExtended/CombatExtended/Verbs/Verb_LaunchProjectileCE.cs

github-actions · 2024-12-02T18:58:50Z

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12126067072.zip

github-actions · 2024-12-03T18:53:18Z

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12146271401.zip

github-actions · 2024-12-03T18:56:44Z

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12146321943.zip

github-actions · 2024-12-03T19:08:05Z

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12146488676.zip

github-actions · 2024-12-03T19:20:07Z

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12146666738.zip

N7Huntsman

Would it make sense to add a visual/audio effect when a skyfaller is intercepted? If they are destroyed by a non-explosive shot, it just sort of pops out a piece of slag and a dead raider.

N7Huntsman · 2025-01-23T13:37:58Z

Defs/Ammo/AmmoBases.xml

+      <li Class="CombatExtended.CompProperties_CIWSImpactHandler">
+        <compClass>CombatExtended.CompCIWSImpactHandler_Projectile</compClass>
+      </li>
+    </comps>
 	</ThingDef>



Are there any performance implications to attaching this comp to every projectile? Would we be better making a completely different base for CIWS projectiles? Or just attaching the comp to the individual CIWS bullets?

Not sure how it affects performance - there's no Tick override, so they should not affect it much.
These components is not intended for CIWS bullets, but for targets

N7Huntsman · 2025-01-23T13:40:00Z

Languages/English/Keyed/Keys.xml

@@ -176,5 +176,17 @@
 	<!-- Shield Information -->
 	<CE_Shield_Coverage>Shield coverage</CE_Shield_Coverage>
 	<CE_Shield_Coverage_Desc>Body parts protected from ranged and melee attacks by the shield.</CE_Shield_Coverage_Desc>
+
+  <!--CIWS-->
+  <CIWSSettings_Copy>Copy</CIWSSettings_Copy>


Is there a vanilla Key we can use for this?

I don't know

MaxDorob · 2025-01-23T14:18:13Z

Would it make sense to add a visual/audio effect when a skyfaller is intercepted? If they are destroyed by a non-explosive shot, it just sort of pops out a piece of slag and a dead raider.

There is a impactEffecter (EffecterDef) in CompCIWSImpactHandler for these purposes

MaxDorob added 30 commits July 27, 2024 23:23

Comps for CIWS (used my comps from vanilla CIWS - https://github.com/…

1752cf0

…MaxDorob/HAETAE_CIWS)

Different projectile def for CIWS-targets

898c4a9

Moved some code to base class

d7115a0

Projectile movement improvments

e085a99

Virtual check collision between

f686568

Moved unused calculations to Init

3cf9ab5

Invoking OnImpact of CIWSTarget

793cda2

Moved moving-forward code to ProjectilePropertiesCE

87b8ab3

Moved NextPositions to ProjectilePropetiesCE

5c7a14b

Returned NextPositions to ProjectileCE

f7c929d

2D segments intersection check

10ae251

NextPosition Changes

343c4cd

Initial commit for CIWS verb

c9d620c

Initial commit for CIWS projectile and turret

b4b8bd1

Name fix

ed04020

Another name fix

45f241c

Temp CalculatePointForPreemptiveFire

6b84eb7

Improved base ciws tick

afc4458

TryFindShotLine for projectile

5746b92

Development merge

c3ca285

Moved PenetrationAmount to ProjectileCE again

725c3db

Moved "MoveForward" logic to ProjectilePropetiesCE again

c2d4704

CompCIWSTarget targeting method call

d23f77d

Count warmup time when trying to predict position Not tested yet (as well as everything else about CIWS)

selecting CIWS projectile if possible for CIWS verbs

315718d

Warning about wrong projectile

6638563

Comp -> Verb

4da40bd

MultiVerb turret

IgnoredDefs changes

ee992cf

Projectile -> ProjectileCE

e6007a7

Validate target moved to base class

ffc8f51

Moved projectile code

c082f99

MaxDorob added 2 commits November 30, 2024 20:26

CIWS icons

b7af0ea

CIWS text

e2f2864

MaxDorob added 3 commits November 30, 2024 21:04

Fixed warning

8a20185

Default values for hold fire

1ddbee5

KPV now able to target skyfallers

fd9c036

Fixed whitespaces

dec17b4

mszabo-wikia reviewed Nov 30, 2024

View reviewed changes

MaxDorob mentioned this pull request Dec 2, 2024

[Patch Request]: Anti-Air: CIWS(Close-In Weapons System) #3573

Open

10 tasks

MaxDorob added 3 commits December 3, 2024 00:41

TryDropThing cleanup

6d99b3d

Another cleanup

945b9f1

typo

373edb0

MaxDorob added 4 commits December 4, 2024 00:39

convert -> cast

ab5151a

Variable names

db11cc0

Created MidBurst property

ea5b006

Removed unused param

22060a6

Moved new properties to other properties

87e172f

MaxDorob added 2 commits December 4, 2024 01:06

Moved comments

87d2cf3

Cleanup

c617309

Removed linq

9cc2ed9

N7Huntsman reviewed Jan 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CIWS v2 #3534

CIWS v2 #3534

MaxDorob commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 30, 2024

github-actions bot commented Nov 30, 2024

github-actions bot commented Nov 30, 2024

github-actions bot commented Nov 30, 2024

mszabo-wikia Nov 29, 2024

mszabo-wikia Nov 29, 2024

MaxDorob Dec 2, 2024

mszabo-wikia Dec 3, 2024

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

N7Huntsman left a comment

N7Huntsman Jan 23, 2025

MaxDorob Jan 23, 2025 •

edited

Loading

N7Huntsman Jan 23, 2025

MaxDorob Jan 23, 2025

MaxDorob commented Jan 23, 2025

CIWS v2 #3534

Are you sure you want to change the base?

CIWS v2 #3534

Conversation

MaxDorob commented Nov 5, 2024 • edited Loading

Additions

Changes

References

ToDo

Testing

Examples

github-actions bot commented Nov 30, 2024

github-actions bot commented Nov 30, 2024

github-actions bot commented Nov 30, 2024

github-actions bot commented Nov 30, 2024

mszabo-wikia Nov 29, 2024

Choose a reason for hiding this comment

mszabo-wikia Nov 29, 2024

Choose a reason for hiding this comment

MaxDorob Dec 2, 2024

Choose a reason for hiding this comment

mszabo-wikia Dec 3, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

github-actions bot commented Dec 3, 2024

N7Huntsman left a comment

Choose a reason for hiding this comment

N7Huntsman Jan 23, 2025

Choose a reason for hiding this comment

MaxDorob Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

N7Huntsman Jan 23, 2025

Choose a reason for hiding this comment

MaxDorob Jan 23, 2025

Choose a reason for hiding this comment

MaxDorob commented Jan 23, 2025

MaxDorob commented Nov 5, 2024 •

edited

Loading

MaxDorob Jan 23, 2025 •

edited

Loading