-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix to restore ABI compatibility with CE < 1.4.5.7 #3052
Conversation
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8533909457.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8568136879.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8568513821.zip |
5c93795
to
b656dc0
Compare
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8576023239.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8576161374.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8578543839.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8578548816.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8579254715.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8579429909.zip |
Changes
Provides explicit getters and caches for mods compiled against the old CE version which cannot easily recompile.
Reasoning
With 1.5 coming out soon, some mod authors have moved on from 1.4, making recompiling against CE 1.4.5.7 difficult. So the most common getters and fields that are no longer needed by CE itself should still be provided for these legacy mods.
Alternatives
Only support mods that can be recompiled against current CE.
Roll back significant performance boosts to our projectiles
Use harmony to monkey patch affected legacy mods
Testing
Check tests you have performed: