Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to restore ABI compatibility with CE < 1.4.5.7 #3052

Merged
merged 19 commits into from
Apr 6, 2024

Conversation

perkinslr
Copy link
Contributor

Changes

Provides explicit getters and caches for mods compiled against the old CE version which cannot easily recompile.

Reasoning

With 1.5 coming out soon, some mod authors have moved on from 1.4, making recompiling against CE 1.4.5.7 difficult. So the most common getters and fields that are no longer needed by CE itself should still be provided for these legacy mods.

Alternatives

Only support mods that can be recompiled against current CE.
Roll back significant performance boosts to our projectiles
Use harmony to monkey patch affected legacy mods

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@perkinslr perkinslr requested review from a team as code owners April 3, 2024 05:54
Copy link

github-actions bot commented Apr 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8533909457.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Apr 3, 2024
Thorbane
Thorbane previously approved these changes Apr 4, 2024
Copy link

github-actions bot commented Apr 5, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8568136879.zip

Copy link

github-actions bot commented Apr 5, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8568513821.zip

Copy link

github-actions bot commented Apr 5, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8576023239.zip

Copy link

github-actions bot commented Apr 5, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8576161374.zip

Copy link

github-actions bot commented Apr 6, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8578543839.zip

Copy link

github-actions bot commented Apr 6, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8578548816.zip

Thorbane
Thorbane previously approved these changes Apr 6, 2024
Copy link

github-actions bot commented Apr 6, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8579254715.zip

Copy link

github-actions bot commented Apr 6, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8579429909.zip

@N7Huntsman N7Huntsman merged commit c6a8512 into backports-1.4 Apr 6, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the projectile-shim branch April 6, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants