Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Big and Small Patches #3027

Conversation

ViralReaction
Copy link
Contributor

@ViralReaction ViralReaction commented Mar 19, 2024

Additions

Describe new functionality added by your code, e.g.

  • Patch pawnkinds added to Big and Small - Heaven and Hell
  • Correct description of armor genes

Changes

Describe adjustments to existing features made in this merge, e.g.

  • Update patches to include new mod names
  • Updated ThirdPartySupport list to include changed mod names

Reasoning

Why did you choose to implement things this way, e.g.

  • Satan pawns kinds spawn without weapons. Vanilla rely on talon genes, but that is insufficient due to CE changes to armor system

Alternatives

Describe alternative implementations you have considered, e.g.

  • Leave Satan pawns using talons only:
    • Ineffectual

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (few minutes to ensure stuff is being patched)

@ViralReaction ViralReaction requested review from a team as code owners March 19, 2024 22:03
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8350684819.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Mar 19, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8350930184.zip

SerinaCE
SerinaCE previously approved these changes Mar 21, 2024
@SerinaCE SerinaCE self-requested a review March 21, 2024 22:50
@SerinaCE
Copy link
Contributor

storno, forgot about the loadfolders migration...

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding this PR til the load folders migration is complete to prevent creating conflicts.

@ViralReaction
Copy link
Contributor Author

I’ll rework PR once migration to load folders is complete.

@N7Huntsman N7Huntsman added the On Hold Being held until after the next release. label Mar 25, 2024
@N7Huntsman N7Huntsman changed the base branch from Development to backports-1.4 April 3, 2024 07:11
@N7Huntsman N7Huntsman dismissed SerinaCE’s stale review April 3, 2024 07:11

The base branch was changed.

Copy link

github-actions bot commented Apr 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8547003488.zip

Copy link

github-actions bot commented Apr 4, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8547127894.zip

@N7Huntsman N7Huntsman merged commit d5de4b5 into CombatExtended-Continued:backports-1.4 Apr 4, 2024
2 checks passed
@N7Huntsman N7Huntsman removed the On Hold Being held until after the next release. label Apr 4, 2024
@N7Huntsman
Copy link
Contributor

I've merged this and ported the changes over to the loadfolder version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants