Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. xml tweak and fixes. #2879

Merged
merged 6 commits into from
Nov 26, 2023
Merged

Misc. xml tweak and fixes. #2879

merged 6 commits into from
Nov 26, 2023

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Nov 8, 2023

Changes

  1. Add Animal Collab Project Vanilla-Style to the FindMod operation to give the animals correct bodyShape.
  2. Update Skeletal Legion FindMod operation and some patch housekeeping.
  3. For CEC & VWE - Quickdraw: Remove operations renaming the weapons to their real-world counterparts.
  4. Update Thog's Guns - More Brukka Pack patch.
  5. Add explicit bulk and wornbulk to some hats from VIE - Hats & Rags, to avoid autopatching.
  6. Fix Archotech Weaponry patch to include melee attacks for the new guns. Close [Patch Request - Update]:Archotech Weaponry #2897

Reasoning

  1. Fixes error.
  2. Simple to do to make the old patch work, and standardize the patch format.
  3. As pointed out by a user on the discord, we have usually renamed guns in patches within Combat Extended: Guns, rather than in the base mod. There's not really a strong case to be made for deviating from standard practice for these guns. So, I've removed the renames here and PR'd them into CE: Guns.
  4. Had a couple of guns (G18 and M82) that needed patched, and FindMod that needed updated. Simple enough.
  5. Preferable to avoid autopatching where we can, though they were being correctly patched as hats in this case.
  6. They'd been overlooked and needed it.

Alternatives

1 + 2 + 6. Leave it broken, I guess.
3 + 4 + 5. Could leave as-is.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners November 8, 2023 23:09
Copy link

github-actions bot commented Nov 8, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6805090915.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6805355513.zip

Copy link

github-actions bot commented Nov 9, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6805741414.zip

Copy link

github-actions bot commented Nov 9, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6806000466.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6843264350.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6942997687.zip

@@ -55,13 +55,6 @@
<researchPrerequisite>PrecisionRifling</researchPrerequisite>
</li>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

positively remember irl names with CE was a feature in the original version of the mod

@N7Huntsman N7Huntsman merged commit 2ac5a94 into Development Nov 26, 2023
2 checks passed
@N7Huntsman N7Huntsman deleted the BugFixes-Tweaks branch November 26, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Patch Request - Update]:Archotech Weaponry
2 participants