Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore: ✨ Turn On/Off Chat Room's Notification Setting API #226

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

psychology50
Copy link
Member

작업 이유

  • Chat members can turn on/off their individual chat room's notification toggle setting.

작업 사항

  • PATCH request: turn on notification
  • DELETE request: turn off notification

리뷰어가 중점적으로 확인해야 하는 부분

  • none

발견한 이슈

image

  • During testing, I turned off notifications for chat rooms 1 and 5, where I had roles as chat admin and chat member respectively.
  • Both operations were processed successfully, but chat room 5 displayed unchanged notification data in the response.
  • The actual status was updated correctly, but the response provided incorrect data when requesting chat room details.

image

@psychology50 psychology50 added the enhancement New feature or request label Jan 22, 2025
@psychology50 psychology50 self-assigned this Jan 22, 2025
@psychology50 psychology50 merged commit 2a12a8f into dev Jan 22, 2025
1 check passed
@psychology50 psychology50 deleted the feat/PW-671-on-off-chatroom-notify branch January 22, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant