Skip to content

Commit

Permalink
Use devtools.gni for devtools_location
Browse files Browse the repository at this point in the history
The Chromium build configuration now defines where DevTools lives.

This requires https://crrev.com/c/3043613 to roll into /build first.

[email protected]

Fixed: 1231495
Change-Id: I2b6721a9541d191492429e9a0027523f7c9bd013
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3043614
Commit-Queue: Tim van der Lippe <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
  • Loading branch information
TimvdLippe authored and Devtools-frontend LUCI CQ committed Jul 22, 2021
1 parent a41f27f commit 2b21feb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
5 changes: 0 additions & 5 deletions build_overrides/BUILDCONFIG.gn
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ declare_args() {
# every toolchain can pass through the "global" value via toolchain_args().
host_toolchain = ""

# Needed to properly resolve the locations for the TypeScript build system
# when we are building for DevTools only. This arg will not be defined in
# Chromium itself.
use_devtools_typescript = true

# DON'T ADD MORE FLAGS HERE. Read the comment above.
}

Expand Down
8 changes: 2 additions & 6 deletions scripts/build/ninja/vars.gni
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,10 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

import("//build/config/devtools.gni")

declare_args() {
devtools_dcheck_always_on = is_debug

if (defined(use_devtools_typescript) && use_devtools_typescript) {
devtools_location = ""
} else {
devtools_location = "third_party/devtools-frontend/src/"
}
}

# Introduce a new variable to make sure that string
Expand Down

0 comments on commit 2b21feb

Please sign in to comment.