Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/radio group direction setters addition #451

Merged

Conversation

MartinBozhilov-coh
Copy link
Contributor

@MartinBozhilov-coh MartinBozhilov-coh commented Aug 6, 2024

  • Self-reviewed and fixed any obvious mistakes, TODOs, removed debugging code, logs, etc
  • Updated package.json in related components, the library or the cli
  • Created tests
  • Tested in a browser
  • Tested in Gameface
  • Created or updated the documentation

https://coherent-labs.atlassian.net/browse/COH-19274

If the next item we want to check is disabled the setCheckedToNextItem function used to call setCheckedToPreviousItem which broke the logic if there are 2 disabled items next to each other
@MartinBozhilov-coh MartinBozhilov-coh merged commit 75d232a into master Aug 6, 2024
3 of 4 checks passed
@MartinBozhilov-coh MartinBozhilov-coh deleted the enhancement/radio-group-direction-setters-addition branch August 6, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants